From owner-freebsd-net  Tue Jul 24 14:43: 4 2001
Delivered-To: freebsd-net@freebsd.org
Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88])
	by hub.freebsd.org (Postfix) with ESMTP
	id 354CA37B405; Tue, 24 Jul 2001 14:43:00 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241])
	by meow.osd.bsdi.com (8.11.4/8.11.2) with ESMTP id f6OLgkv24683;
	Tue, 24 Jul 2001 14:42:46 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.010724144243.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20010724143734.A1412@Odin.AC.HMC.Edu>
Date: Tue, 24 Jul 2001 14:42:43 -0700 (PDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Brooks Davis <brooks@one-eyed-alien.net>
Subject: RE: review request: ng_split cleanup
Cc: hackers@FreeBSD.org, net@FreeBSD.org
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org


On 24-Jul-01 Brooks Davis wrote:
> Please review the following diff for the ng_split netgraph node.  It
> cleans up a number of style issues, removes some functions that just did
> that the default functions did, and renames the node to split from
> ng_split to follow the normal convention.  In addition to this diff, I
> plan to commit a Makefile update to make this part of the modules build
> and a sys/conf/options entry to allow static compilation.
> 
> Thanks,
> Brooks
> 
> Index: ng_split.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/netgraph/ng_split.c,v
> retrieving revision 1.1
> diff -u -r1.1 ng_split.c
> --- ng_split.c        2001/02/22 17:14:34     1.1
> +++ ng_split.c        2001/07/24 21:37:28
> @@ -1,5 +1,4 @@
> -/*-
> - *
> +/*
>   * Copyright (c) 1999-2000, Vitaly V Belekhov
>   * All rights reserved.
>   *

This hunk is needed for lint(1) to recognize special comments.  Don't remove it.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message