From owner-freebsd-geom@FreeBSD.ORG Tue Jan 27 06:57:05 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B193216A4CE for ; Tue, 27 Jan 2004 06:57:05 -0800 (PST) Received: from milla.ask33.net (milla.ask33.net [217.197.166.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9690643D6D for ; Tue, 27 Jan 2004 06:56:50 -0800 (PST) (envelope-from nick@milla.ask33.net) Received: by milla.ask33.net (Postfix, from userid 1001) id ED57A3ABB53; Tue, 27 Jan 2004 15:57:53 +0100 (CET) Date: Tue, 27 Jan 2004 15:57:53 +0100 From: Pawel Jakub Dawidek To: Lukas Ertl Message-ID: <20040127145753.GM565@garage.freebsd.pl> References: <20040127154303.E92925@pcle2.cc.univie.ac.at> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="AQNmCumFClRcGgHG" Content-Disposition: inline In-Reply-To: <20040127154303.E92925@pcle2.cc.univie.ac.at> X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc X-OS: FreeBSD 4.8-RELEASE-p13 i386 X-URL: http://garage.freebsd.pl User-Agent: Mutt/1.5.1i cc: freebsd-geom@freebsd.org Subject: Re: Error checking for g_mod_event() and friends X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2004 14:57:05 -0000 --AQNmCumFClRcGgHG Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 27, 2004 at 03:46:30PM +0100, Lukas Ertl wrote: +> is there a specific reason that the .init function of a class is declared +> to return "void"? I'd like to change that to an int, so we could do err= or +> checking, and subsequently modify g_load_class() to check for errors and +> so on. Look at: http://garage.freebsd.pl/patches/geom_subr.c.patch The biggest problem is that g_event thread is created after classes are loaded, so we end up with deadlock on boot. +> Additionally, I've seen several calls to g_malloc() where the return +> values aren't checked - should I prepare some patches for these? I don't see any g_malloc() call with M_NOWAIT. --=20 Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net --AQNmCumFClRcGgHG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBQBZ8cT/PhmMH/Mf1AQG+rwQAg2DLwd4CakKZTPFTP8+cgE3hS4RPFlxV nN6F6KM+IYVwuTgDCVJ1RP2fJg+KksphVCJOHN2g8UlWkLJIr7HfTi3Y+/cu8i04 9NVbuIPwcQ5P0QRNy83vSAbZPDeG9I2wxdjqv/4s5wekzEQL5ZmxmxhLstiCgez9 6nRFYv//PWk= =vIFh -----END PGP SIGNATURE----- --AQNmCumFClRcGgHG--