Date: Wed, 4 Nov 2020 15:37:48 -0700 From: Alan Somers <asomers@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Rick Macklem <rmacklem@uoguelph.ca>, Alan Somers <asomers@freebsd.org>, freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: Always-0 NFS statistics Message-ID: <CAOtMX2j_wKBAqbCyiKg0YLXETVJSnVZRvO%2BdHL_2RwOwjXSsKw@mail.gmail.com> In-Reply-To: <CAPyFy2C7jd1PzWrDR6Se5oY7KPTxhjojmjo=J8a%2B0MYb=fh9Lw@mail.gmail.com> References: <CAOtMX2jW_3dg6=EiM=xJNs5F5EYveaE4ShGZFAXcFNbxJuoRMw@mail.gmail.com> <YTBPR01MB396692E2EC66728FBB692231DD1A0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> <CAPyFy2C7jd1PzWrDR6Se5oY7KPTxhjojmjo=J8a%2B0MYb=fh9Lw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 4, 2020 at 3:08 PM Ed Maste <emaste@freebsd.org> wrote:
> On Thu, 22 Oct 2020 at 21:46, Rick Macklem <rmacklem@uoguelph.ca> wrote:
> >
> > >nfsstat's name kernel name
> > >Retfailed srv_errs
> > >Faults srvrpc_errs
> > >Idem srvcache_idemdonehits
> > I believe these are left over from when the code was originally written
> > for OpenBSD2.6, which did not have a separate kernel RPC, where the
> > NFS code did the RPC calls.
> >
> > I suppose they should have been deleted from the FreeBSD port once
> > it was incorporated into FreeBSD using the kernel RPC, but they were
> > not.
> >
> > Revising the nfsstats structure yet again is a bother.
> > I suppose you could modify nfsstats.c so that it never displays these
> > fields. I doubt that would be considered a POLA violation.
>
> Would it make sense to also rename them to int reserved_{1,2,3} to
> make it clear in kernel that they're unused?
>
Yes, that would be a good idea.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2j_wKBAqbCyiKg0YLXETVJSnVZRvO%2BdHL_2RwOwjXSsKw>