From owner-cvs-all Tue Dec 5 15:11:39 2000 From owner-cvs-all@FreeBSD.ORG Tue Dec 5 15:11:36 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from pcnet1.pcnet.com (pcnet1.pcnet.com [204.213.232.3]) by hub.freebsd.org (Postfix) with ESMTP id 92D7437B400; Tue, 5 Dec 2000 15:11:35 -0800 (PST) Received: (from eischen@localhost) by pcnet1.pcnet.com (8.8.7/PCNet) id SAA26617; Tue, 5 Dec 2000 18:11:14 -0500 (EST) Date: Tue, 5 Dec 2000 18:11:14 -0500 (EST) From: Daniel Eischen To: Alfred Perlstein Cc: "David O'Brien" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm phys_pager.c In-Reply-To: <20001205145908.K8051@fw.wintelcom.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, 5 Dec 2000, Alfred Perlstein wrote: > * David O'Brien [001205 14:31] wrote: > > On Tue, Dec 05, 2000 at 02:23:11PM -0800, Alfred Perlstein wrote: > > > Modified files: (Branch: RELENG_4) > > > sys/vm phys_pager.c > > > Log: > > > MFC: 1.4 (handle non PAGE_SIZE requests properly) > > > > Uh.. what happened to letting it settle in -current first... > > Didn't this *same* discussion come up just last week... perhaps you are > > a little too 'D'elete key happy. > > 1) I tested it under -stable before -current. > 2) I needed it working. > 3) It was a bugfix and needed. > 4) It defaults to off in all systems. > 5) It was reviewed. > 6) I have extreme doubts that anyone could have been using it reliably > before my fix. > 7) It's been broken for many months, I finally spent all night tracking > it down and the Maintainer (peter) didn't seem interested in chasing > down the problem when I told him about it months ago. I don't want to pick on Alfred; just using this as a platform. For problems that don't affect the majority of folks and is not a security related problem, there is no reason *not* to wait to MFC. I'd like to see all fixes like this settle for at least a day or two, just to make sure that world wasn't accidentally broken. -- Dan Eischen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message