From owner-svn-src-all@FreeBSD.ORG Tue Jun 15 08:03:15 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7816C1065676; Tue, 15 Jun 2010 08:03:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id DD4AD8FC1E; Tue, 15 Jun 2010 08:03:14 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o5F839JD023780 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Jun 2010 11:03:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o5F8392u001703; Tue, 15 Jun 2010 11:03:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o5F8396T001702; Tue, 15 Jun 2010 11:03:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 15 Jun 2010 11:03:09 +0300 From: Kostik Belousov To: Andriy Gapon Message-ID: <20100615080309.GK13238@deviant.kiev.zoral.com.ua> References: <201006150706.o5F76sLF004481@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ys8nbMVQRzTucb0g" Content-Disposition: inline In-Reply-To: <201006150706.o5F76sLF004481@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-2.3 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_50, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209193 - head/sys/dev/sound/pcm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2010 08:03:15 -0000 --ys8nbMVQRzTucb0g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 15, 2010 at 07:06:54AM +0000, Andriy Gapon wrote: > Author: avg > Date: Tue Jun 15 07:06:54 2010 > New Revision: 209193 > URL: http://svn.freebsd.org/changeset/base/209193 >=20 > Log: > sound/pcm: use non-const string as a value with SYSCTL_STRING > =20 > Although the sysctls are marked with CTLFLAG_RD and the values will stay > immutable, current sysctl implementation stores value pointer in > void* type, which means that const qualifier is discarded anyway > and some newer compilers complaint about that. > We can't use de-const trick in sysctl implementation, because in that > case we could miss an opposite situation where a const value is used > with CTLFLAG_RW sysctl. > =20 > Complaint from: gcc 4.4, clang > MFC after: 2 weeks This is arguably the change for worse then better. You could add SYSCTL_STRING_CONST or the like instead. --ys8nbMVQRzTucb0g Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkwXM70ACgkQC3+MBN1Mb4in3gCfR0ic4KJppz/g6mONIsP7gbLW uPUAn3k+dw9z5FOfujlyWf9M1xoaCeas =vn8Z -----END PGP SIGNATURE----- --ys8nbMVQRzTucb0g--