From owner-svn-src-head@FreeBSD.ORG  Tue Nov 25 17:41:35 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B17FC1065672;
	Tue, 25 Nov 2008 17:41:35 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from mail.farley.org (farley.org [67.64.95.201])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D9828FC20;
	Tue, 25 Nov 2008 17:41:35 +0000 (UTC) (envelope-from scf@FreeBSD.org)
Received: from thor.farley.org (HPooka@thor.farley.org [192.168.1.5])
	by mail.farley.org (8.14.3/8.14.3) with ESMTP id mAPHQx9C020676;
	Tue, 25 Nov 2008 11:26:59 -0600 (CST) (envelope-from scf@FreeBSD.org)
Date: Tue, 25 Nov 2008 11:26:59 -0600 (CST)
From: "Sean C. Farley" <scf@FreeBSD.org>
To: =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
In-Reply-To: <86wsetfd36.fsf@ds4.des.no>
Message-ID: <alpine.BSF.2.00.0811251125220.3927@thor.farley.org>
References: <200811232326.mANNQCLp067323@svn.freebsd.org>
	<86wsetfd36.fsf@ds4.des.no>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="56599777-309033472-1227634019=:3927"
X-Spam-Status: No, score=-4.4 required=3.0 tests=ALL_TRUSTED,BAYES_00
	autolearn=ham version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on mail.farley.org
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r185237 - head/lib/libutil
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2008 17:41:35 -0000

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--56599777-309033472-1227634019=:3927
Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8BIT

On Mon, 24 Nov 2008, Dag-Erling Smørgrav wrote:

> Sean Farley <scf@FreeBSD.org> writes:
>> Log:
>>   Fixed style issues with variable ordering and naming, spacing and
>>   parentheses.
>>
>>   Fixed alignment issue in gr_dup() in its assignment of gr_mem using a
>>   struct to force alignment without performing alignment mathematics.  This
>>   was noticed recently with libutil was built with WARNS=6 on platform such
>>   as sparc64.
>>
>>   Added checks to gr_dup(), gr_equal() and gr_make() to prevent segfaults
>>   when examining struct group's with the struct members pointing to NULL's.
>>
>>   With fix of alignment issue, restore WARNS?=6.
>
> Good work, thank you!

You are welcome.  Thank you too for the help on the alignment issue and
plethora of style questions.  :)

Sean
-- 
scf@FreeBSD.org
--56599777-309033472-1227634019=:3927--