From owner-svn-src-head@freebsd.org  Wed Jan  4 01:44:46 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4685C9C47F;
 Wed,  4 Jan 2017 01:44:46 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B3FD31957;
 Wed,  4 Jan 2017 01:44:46 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v041ijkp013586;
 Wed, 4 Jan 2017 01:44:45 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v041iji4013585;
 Wed, 4 Jan 2017 01:44:45 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201701040144.v041iji4013585@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Wed, 4 Jan 2017 01:44:45 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r311222 - head/usr.sbin/bsnmpd/tools/libbsnmptools
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 01:44:47 -0000

Author: ngie
Date: Wed Jan  4 01:44:45 2017
New Revision: 311222
URL: https://svnweb.freebsd.org/changeset/base/311222

Log:
  Fix logical inversion when checking result from calloc
  in snmp_output_err_resp(..)
  
  X-MFC with:	r310987
  MFC after:	3 days
  Reported by:	Coverity
  CID:		1368195

Modified:
  head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c

Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c
==============================================================================
--- head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c	Wed Jan  4 01:38:07 2017	(r311221)
+++ head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c	Wed Jan  4 01:44:45 2017	(r311222)
@@ -2011,7 +2011,7 @@ snmp_output_err_resp(struct snmp_toolinf
 		return;
 	}
 
-	if ((object = calloc(1, sizeof(struct snmp_object))) != NULL) {
+	if ((object = calloc(1, sizeof(struct snmp_object))) == NULL) {
 		fprintf(stdout, "calloc: %s", strerror(errno));
 		return;
 	}