From owner-cvs-all  Thu Jun  4 16:59:03 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id QAA11481
          for cvs-all-outgoing; Thu, 4 Jun 1998 16:59:03 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA11323;
          Thu, 4 Jun 1998 16:58:21 -0700 (PDT)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id JAA30226;
	Fri, 5 Jun 1998 09:58:13 +1000
Date: Fri, 5 Jun 1998 09:58:13 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199806042358.JAA30226@godzilla.zeta.org.au>
To: dima@tejblum.dnttm.rssi.ru, peter@netplex.com.au
Subject: Re: cvs commit: src/sys/nfs nfs_vnops.c
Cc: asami@FreeBSD.ORG, committers@FreeBSD.ORG, jdp@polstra.com
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>I think, NFS may and should pretend that chflags(..., 0) succeed.

No.  The lower layers should pass errors up so that the highest layer
can decide what to do.

>Nobody 
>would notice any difference, anyway :-)

Bug in wetware layer :-).

>msdosfs do so since 1994 (rev. 1.11 
>of msdosfs_vnops.c). (It returns EINVAL rather than EOPNOTSUPP, though. 
>I plan to change it.)

EINVAL was reasonable.  msdosfs_settattr() returns EINVAL for several
other things that it doesn't really support.  For chown/chgrp, this
is even correct.  It supports null changes, and other changes are
invalid :-).  Perhaps chflags() should be handled similarly.  Setting
the flags to 0 should just work.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message