From owner-freebsd-threads@FreeBSD.ORG Mon Jan 28 19:19:18 2008 Return-Path: Delivered-To: freebsd-threads@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5F8C16A417; Mon, 28 Jan 2008 19:19:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id BCC6B13C4EF; Mon, 28 Jan 2008 19:19:18 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id BD23C497A4; Mon, 28 Jan 2008 13:59:27 -0500 (EST) Date: Mon, 28 Jan 2008 18:59:27 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Daniel Eischen In-Reply-To: Message-ID: <20080128185830.B56811@fledge.watson.org> References: <200801240850.m0O8o2JQ023500@freefall.freebsd.org> <4798564B.7070500@elischer.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Gary Stanley , Julian Elischer , freebsd-threads@freebsd.org Subject: Re: threads/119920: fork broken in libpthread X-BeenThere: freebsd-threads@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Threading on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 19:19:19 -0000 On Thu, 24 Jan 2008, Daniel Eischen wrote: >> dan what IS the fix for this? I assume you must have fixed it in >> -current/7 > > You want cvs diff -u -r1.126 -r1.128 src/lib/libkse/thread/thr_kern.c. The > WARNS'ify diffs are not necessary, so it should look something like shown > below. Probably an MFC of all of libkse (minus jasone's malloc changes) > should be done to -7 and -6. Should the patch be considered for an errata notice for 6.x? Should we be trying to MFC this to 7.x for inclusion with 7.0 or does it need more time to shake out and should potentially be a 7.0 errata notice or just appear in 7.1? Robert N M Watson Computer Laboratory University of Cambridge