From owner-svn-src-head@FreeBSD.ORG  Mon Nov 15 00:14:31 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3AB74106576B;
	Mon, 15 Nov 2010 00:14:31 +0000 (UTC) (envelope-from andy@fud.org.nz)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 54C2A8FC14;
	Mon, 15 Nov 2010 00:14:29 +0000 (UTC)
Received: by wyb36 with SMTP id 36so1988534wyb.13
	for <multiple recipients>; Sun, 14 Nov 2010 16:14:29 -0800 (PST)
MIME-Version: 1.0
Received: by 10.227.29.92 with SMTP id p28mr5352524wbc.70.1289778708696; Sun,
	14 Nov 2010 15:51:48 -0800 (PST)
Sender: andy@fud.org.nz
Received: by 10.227.146.67 with HTTP; Sun, 14 Nov 2010 15:51:48 -0800 (PST)
In-Reply-To: <alpine.LNX.2.00.1011142254160.23661@ury.york.ac.uk>
References: <201011142041.oAEKfN6Y093321@svn.freebsd.org>
	<alpine.LNX.2.00.1011142254160.23661@ury.york.ac.uk>
Date: Mon, 15 Nov 2010 12:51:48 +1300
X-Google-Sender-Auth: h3mP9bKrH-y9GqyEH6qr4mBTuWg
Message-ID: <AANLkTikYTE5f9dUmVySt_bRtAp-gQ4nPYe5S4ZQUQVNm@mail.gmail.com>
From: Andrew Thompson <thompsa@FreeBSD.org>
To: Gavin Atkinson <gavin@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r215319 - head/sys/arm/xscale/ixp425
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Nov 2010 00:14:31 -0000

On 15 November 2010 11:56, Gavin Atkinson <gavin@freebsd.org> wrote:
> On Sun, 14 Nov 2010, Andrew Thompson wrote:
>
>> Author: thompsa
>> Date: Sun Nov 14 20:41:22 2010
>> New Revision: 215319
>> URL: http://svn.freebsd.org/changeset/base/215319
>>
>> Log:
>> =A0 Provide a mutex around the read/modify/write of the IXP425_GPIO_*
>> =A0 registers. Giant was used in some places, but not all.
>
> I believe this should fix my PR arm/134338, but don't have the bandwidth
> at the moment to verify that. =A0Is there any chance you could see if you
> believe the same?

It is essentially the same. I have not added locks around the
probe/attach routines as interrupts/scheduler are still disabled.


Andrew