From owner-p4-projects@FreeBSD.ORG Tue May 19 15:28:07 2009 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 605CA1065679; Tue, 19 May 2009 15:28:07 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1414C1065673; Tue, 19 May 2009 15:28:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id D9FD78FC26; Tue, 19 May 2009 15:28:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 8EB8546B17; Tue, 19 May 2009 11:28:06 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 831CE8A025; Tue, 19 May 2009 11:28:05 -0400 (EDT) From: John Baldwin To: Zhao Shuai Date: Tue, 19 May 2009 09:47:23 -0400 User-Agent: KMail/1.9.7 References: <200905171226.n4HCQXS9011874@repoman.freebsd.org> <3bbf2fe10905170632g7ad74f3dk3cdb3ad5576da394@mail.gmail.com> <8126ef5c0905180707w7c238133q37e3d42ea321ead2@mail.gmail.com> In-Reply-To: <8126ef5c0905180707w7c238133q37e3d42ea321ead2@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905190947.23665.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Tue, 19 May 2009 11:28:05 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Attilio Rao , Perforce Change Reviews Subject: Re: PERFORCE change 162206 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2009 15:28:08 -0000 On Monday 18 May 2009 10:07:01 am Zhao Shuai wrote: > Yes, that is an elegant solution and I will do that. > What's your opinion, John? > > This week I just wanna make fifo work using the existing > pipe code, so current modification in pipe code looks ugly. > But I think it helps me to figure out which part of pipe code > can be shared. I agree with both counts. > 2009/5/17 Attilio Rao > > > > > I'm not sure how do you and John want to organize the work, but when I > > was thinking about it my main idea was firstly to refactorize the pipe > > code, identifying common parts that can be shared and put under > > subr_something.c (for example) to be sucked in by both pipes and FIFOs > > main code. > > > > > -- > Regards, > Zhao > -- John Baldwin