From owner-freebsd-current@freebsd.org Fri Jan 8 01:07:51 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4979EA665A3 for ; Fri, 8 Jan 2016 01:07:51 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) by mx1.freebsd.org (Postfix) with ESMTP id 0C9C018BA; Fri, 8 Jan 2016 01:07:50 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id HLWtaHDwakK49HLWuapBBj; Thu, 07 Jan 2016 18:07:49 -0700 X-Authority-Analysis: v=2.1 cv=AMkI9oPf c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=BWvPGDcYAAAA:8 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=VxmjJ2MpAAAA:8 a=kj9zAlcOel0A:10 a=7aQ_Q-yQQ-AA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=mfRIrPh3G6jrFTjFlicA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 9AE93138DE; Thu, 7 Jan 2016 17:07:47 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u0817kDw078603; Thu, 7 Jan 2016 17:07:46 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201601080107.u0817kDw078603@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Adrian Chadd cc: Cy Schubert , Jeremie Le Hen , Ryan Stone , FreeBSD Current , =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= Subject: Re: Panic from vesa_configure() In-Reply-To: Message from Adrian Chadd of "Thu, 07 Jan 2016 08:53:32 -0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 07 Jan 2016 17:07:46 -0800 X-CMAE-Envelope: MS4wfNlUhhof8w3awv0QBuHdqmZ0T7fSMieCXzUOOACRBxqi3Abg1zaPlIoNVwT6fBqWltJdWp7MsiXXgR0EAAMwNSZ1CAI5qMIdPnHKaPhHlfnUW7l2a7gB /P8xs52UIZT3nnXPG2ww0zVWJdEH6NDBU9Rsym2U7WjcbO+gHkvzZPcdjv58ONB1FJg7ZLjzk5p7gShYd7Iu46yqhI+qLDc85G/Z7X9bdRnzsdyApaFmeFre +KFZnCGRT9B728++JD43M5nc6HJuVlXmAnefERvf7V6PFpHDzM/0X0FTmX29LE3Yan8icWUE/kV5DAyp2m7P4A== X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 01:07:51 -0000 In message , Adrian Chadd writes: > Ok, > > So try adding this check: > > vmbuf = x86bios_alloc(&offs, sizeof(*buf), M_WAITOK); > if (vmbuf == NULL) { > printf("%s: x86bios_alloc failed!\n", __func__); > goto fail; > } > > ... that call shouldn't be failing, but if it's truely failing on the > bcopy(), the only reason is because vmbuf is NULL. Thanks. I'll try this. vesa.c hasn't changed for a while so I suspect the root cuase may be somewhere else (we're probably treating the symptom here). Nice thing about using the same mobo and cpu combination on all my machines (except laptops), failures are completely reproducible. Might be a good idea to put in a dtrace probe too. -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.