From owner-svn-src-head@freebsd.org Thu Dec 17 15:02:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62A724BA5E6; Thu, 17 Dec 2020 15:02:18 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CxZwV2Jrjz3mMW; Thu, 17 Dec 2020 15:02:18 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-ej1-f42.google.com with SMTP id 6so23667488ejz.5; Thu, 17 Dec 2020 07:02:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3A29Ez4cnkuCUvXWh+TSEKm/nSgduU5+/WRJQC3X1Bo=; b=alo+1AC3U33DCkMEQ+xETiGBCXpioy6Fam7BEDwQhrmi+9P8hJaVaJNhKTPL1lqwwP 7MaFYPsDjxYqvFL6h06UguZmAVkcXlxB4xlecTEeIx6Ht2wPA3963KaaS8HyECRah4O7 KeGP2TfrI0vuV0TR4JVCWUmCErpm72kCeIA9ZU/tzGuC06n3cKFk5XUNfr5x57GcdBNR MEJGzn8JXnXlzSd+zOsr4xnGGAf63CYiCtiKzPFaNQWywHSyT7WZoXA7VvcddOsyNXvD audVvW8+Jy9BTgqofbdawynHHLO0Jl1kDiv8B2VFjNN8emITWz+MvyfT8qIuW9PdDXMb PiVg== X-Gm-Message-State: AOAM533vH7bTDHN/+wfxYHxkKCjmlZFd7rIEkClLQBoFn5DuU653uiZL JjJ3sdjLgJJSoJmyxCTgJ277icdwwomow6CAFlQ= X-Google-Smtp-Source: ABdhPJzEAJM+Q7O8zR9LPy4oGvLqSO0tY7+Qe1mKsAJn8xRHOwm9eZ4hPnZOEfYjs5ouz//P8tkO51GvV3Jpa0G6dPY= X-Received: by 2002:a17:906:cecd:: with SMTP id si13mr15552929ejb.441.1608217336635; Thu, 17 Dec 2020 07:02:16 -0800 (PST) MIME-Version: 1.0 References: <202012160902.0BG92A19072702@repo.freebsd.org> In-Reply-To: From: Antoine Brodin Date: Thu, 17 Dec 2020 16:02:05 +0100 Message-ID: Subject: Re: svn commit: r368692 - in head: include/xlocale lib/libc/include lib/libc/nls lib/libc/string To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CxZwV2Jrjz3mMW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 15:02:18 -0000 On Thu, Dec 17, 2020 at 11:07 AM Konstantin Belousov wrote: > > On Thu, Dec 17, 2020 at 10:32:14AM +0100, Antoine Brodin wrote: > > On Wed, Dec 16, 2020 at 10:02 AM Konstantin Belousov wrote: > > > > > > Author: kib > > > Date: Wed Dec 16 09:02:09 2020 > > > New Revision: 368692 > > > URL: https://svnweb.freebsd.org/changeset/base/368692 > > > > > > Log: > > > Implement strerror_l(). > > > > > > Only for the arches that provide user-mode TLS. > > > > > > PR: 251651 > > > Requested by: yuri > > > Discussed with: emaste, jilles, tijl > > > Sponsored by: The FreeBSD Foundation > > > Differential revision: https://reviews.freebsd.org/D27495 > > > MFC after: 2 weeks > > > > Hi, > > > > It seems that this change broke some ports. > > For instance: > > http://gohan03.nyi.freebsd.org/data/head-amd64-default-baseline/p558245_s368709/logs/errors/p11-kit-0.23.22.log > > p11-kit does strange/stupid thing. It checks for strerror_l() without > namespace restriction, but then in common/message.c, before actually using it, > it does > #define _POSIX_C_SOURCE 200112L > > Could you please try the following, which might be a right thing to do > regardless p11-kit quirk. Hi, This change fixes p11-kit. Cheers, Antoine > diff --git a/include/string.h b/include/string.h > index 3c5cceaeb85..774cf5fe975 100644 > --- a/include/string.h > +++ b/include/string.h > @@ -140,7 +140,7 @@ int timingsafe_bcmp(const void *, const void *, size_t); > int timingsafe_memcmp(const void *, const void *, size_t); > #endif /* __BSD_VISIBLE */ > > -#if __POSIX_VISIBLE >= 200809 || defined(_XLOCALE_H_) > +#if __POSIX_VISIBLE >= 200112 || defined(_XLOCALE_H_) > #include > #endif >