From owner-freebsd-gnome@FreeBSD.ORG Fri Feb 27 10:34:14 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7798A106564A; Fri, 27 Feb 2009 10:34:14 +0000 (UTC) (envelope-from andrew.w.nosenko@gmail.com) Received: from mail-bw0-f164.google.com (mail-bw0-f164.google.com [209.85.218.164]) by mx1.freebsd.org (Postfix) with ESMTP id 9B2A48FC0A; Fri, 27 Feb 2009 10:34:13 +0000 (UTC) (envelope-from andrew.w.nosenko@gmail.com) Received: by bwz8 with SMTP id 8so942835bwz.43 for ; Fri, 27 Feb 2009 02:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=1ARBG/hS5lXVDrFz71d7VxKhmeuXl0A0lvWI2rMLbEI=; b=PtGcP+TYMxJQOtbP1Ll3Jr25w9ytCmUoDcqqjstANYdyBaEXf/qdESKHq5tUq4QLbh miaPxfE6C7wAwSYHloZ2lzj2f/vbDHiFScgdZOLgtXOSdAat3GjTqj08vbhc2ii4+TUn I2vZMIoCx0LtVaz/Ol8iIUru+8dw7Lrhbcj7k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=X4yBnJ8VMLEViz91W+1ny91Qw+jnfnAfHdz/tynLi2QBJs0PIxcXBO+RXaGxE1Fm7Y padQKeswPVP6OSTuDtwgdvR+lVuSQu7I/vBWYKB8YM1Ry1yeqd1vnX7aT2+EckWz/8tM n1hiN1VihxmUVGzLpSmywEmwlleUHs0jwfO1g= MIME-Version: 1.0 Received: by 10.180.231.17 with SMTP id d17mr822458bkh.37.1235730852337; Fri, 27 Feb 2009 02:34:12 -0800 (PST) In-Reply-To: <20090226223059.9e23c3dc.stas@FreeBSD.org> References: <20090224021026.ba40bdc2.stas@FreeBSD.org> <1235598615.3297.60.camel@shumai.marcuscom.com> <20090226171804.8681e79c.stas@FreeBSD.org> <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> <20090226223059.9e23c3dc.stas@FreeBSD.org> Date: Fri, 27 Feb 2009 12:34:12 +0200 Message-ID: <6161f3180902270234t4d70cae0i900fe470939d0f9d@mail.gmail.com> From: "Andrew W. Nosenko" To: Stanislav Sedov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: [FreeBSD port]: devel/glib20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2009 10:34:14 -0000 On Thu, Feb 26, 2009 at 9:30 PM, Stanislav Sedov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Thu, 26 Feb 2009 16:53:16 +0200 > "Andrew W. Nosenko" mentioned: > >> On Thu, Feb 26, 2009 at 4:18 PM, Stanislav Sedov wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > On Wed, 25 Feb 2009 16:50:15 -0500 >> > Joe Marcus Clarke mentioned: >> > >> >> On Tue, 2009-02-24 at 02:10 +0300, Stanislav Sedov wrote: >> >> > -----BEGIN PGP SIGNED MESSAGE----- >> >> > Hash: SHA1 >> >> > >> >> > Hi! >> >> > >> >> > glib20 has a known filename encoding problem with non-utf8 >> >> > locales, because it doesn't perform names conversion from >> >> > internal UTF8 to current locale by default (it used to do >> >> > that some time ago). The patch included changes glib20 >> >> > behaviour to always do the conversion (this will work >> >> > for all non-UTF8 locales and will have no effect fot UTF8 >> >> > ones). This is effectively the same redhat & co does in >> >> > their deistributions. >> >> > >> >> > Comments? >> >> >> >> I have no objection, but I don't typically run into problems with >> >> non-UTF-8 locales. I think it would be safer if you made this into an >> >> OPTION, and added this as an extra patch if the OPTION is enabled. >> >> >> > >> > Doesn't running gtk/glib (e.g. sylpheed, gimp) apps with non-UTF locale >> > break filenames for you? From looking into the code it's always the case >> > for non-UTF locales (well, if you running ISO8859-1 you shouldn't have >> > problems too). On the other hand enabling LANG-based locale detection should >> > not hurt prefromance much (I think the overhead of parsing LANG is neglible). >> > Sure, we can OPTIONfy this, but I belive the options should be enabled by >> > default in this case (otherwise, people will continue to step onto this >> > bug). Major Linux distributions also have this option turned on by default >> > to match the behavior of older version of glib where the locale detection >> > code was always enabled. >> > >> >> Why you want to patch Glib for turn this behavior on by default >> instead of just install file in the /usr/local/etc/profile.d ? >> >> profile.d approrach is reversible (I can unset enviroment variable), >> while patching Glib for remove patch ... slightly ugly at least, >> IMHO. >> > > Hmm, I didn't knew about this possible way. What kind of file should > be installed here? Is it something specific to glib? No. It just collection of files that included by the '.' (dot) command of shell into .profile execution chain. Something like $ echo 'G_BROKEN_FILENAMES=yes' > /usr/local/etc/profile.d/glib20.sh $ chmod +x /usr/local/etc/profile.d/glib20.sh But I personally would to prefer UTF-8 filenames even when under koi8-u locale, because it gives highly better interoperability between desktops (GOME/KDE/XFCE) and users (some uses German at all just for don't forget this language). My personal vote: leave Glib as it is. Everything what you want may be ahieved just by tuning environment variables. -- Andrew W. Nosenko