Date: Mon, 17 Jul 2023 07:53:54 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: FreeBSD Mailing List <freebsd-ports@freebsd.org>, Po-Chuan Hsieh <sunpoet@freebsd.org> Subject: Re: www/node18 fails to build on aarch64/current Message-ID: <CAFDf7U%2BHW%2BeKREA4wwvVjGk%2BtR6FF3hRtQxg6r%2BPDh39Ye3HAw@mail.gmail.com> In-Reply-To: <CAFDf7UJe0pLKUag4%2BSXs-iS2vWQ45P-Av-BM9EPO2aXLpE7X1g@mail.gmail.com> References: <CAFDf7ULB281n-aiWt5MVuo1XPjwbYhPf2GpVHnZonN0PF4YquQ@mail.gmail.com> <06E66577-0A59-4BCD-BCD8-9C1BC2B6F17C@FreeBSD.org> <CAFDf7UJe0pLKUag4%2BSXs-iS2vWQ45P-Av-BM9EPO2aXLpE7X1g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000b7a66b0600a9439d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
I can confirm that it builds.
Should a PR be open or this is being taken already?
Thanks,
Nuno Teixeira <eduardo@freebsd.org> escreveu no dia domingo, 16/07/2023
=C3=A0(s) 14:24:
> Hello Dimitry!
>
> Thanks, I didn't see that PR since I only searched node18...
>
> I'm building it right now with:
>
> +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091
> +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion
> +.endif
>
> Tomorrow I will have results.
>
> Thanks!
>
> Dimitry Andric <dim@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=
=A0(s)
> 14:10:
>
>> On 16 Jul 2023, at 14:58, Nuno Teixeira <eduardo@freebsd.org> wrote:
>> >
>> > main 1400093 aarch64
>> >
>> > Anyone seeing www/node18 failing (needed for www/firefox)?
>> > I tried reverting latest 2 committs and same result with 18.16.0.
>> >
>> > Any hints?
>> >
>> > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log
>> > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log
>>
>> These are similar to <https://bugs.freebsd.org/272013>, but instead of
>> properly fixing it, the can was kicked down the road in <
>> https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de=
82b8dd49950d
>> >.
>>
>> These enums should be fixed by either removing the values outside of the
>> enum's valid range, or by specifying the enum's underlying type explicit=
ly
>> to allow for such values. In the near future the
>> -Wno-enum-constexpr-conversion flag is going to go away!
>>
>> -Dimitry
>>
>>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
--=20
Nuno Teixeira
FreeBSD Committer (ports)
--000000000000b7a66b0600a9439d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>I can confirm that it builds.</div><div><br></div><di=
v>Should a PR be open or this is being taken already?</div><div><br></div><=
div>Thanks,<br></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">Nuno Teixeira <<a href=3D"mailto:eduardo@freebsd.or=
g">eduardo@freebsd.org</a>> escreveu no dia domingo, 16/07/2023 =C3=A0(s=
) 14:24:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div di=
r=3D"ltr"><div>Hello Dimitry!</div><div><br></div><div>Thanks, I didn't=
see that PR since I only searched node18...</div><div><br></div><div>I'=
;m building it right now with:</div><div><br></div><div><div>+.if ${OPSYS} =
=3D=3D FreeBSD && ${OSVERSION} >=3D 1400091</div><div>+CXXFLAGS+=
=3D -Wno-error=3Denum-constexpr-conversion</div><div>+.endif</div><div><br>=
</div><div>Tomorrow I will have results.</div><div><br></div><div>Thanks!<b=
r></div></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=
=3D"gmail_attr">Dimitry Andric <<a href=3D"mailto:dim@freebsd.org" targe=
t=3D"_blank">dim@freebsd.org</a>> escreveu no dia domingo, 16/07/2023 =
=C3=A0(s) 14:10:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
>On 16 Jul 2023, at 14:58, Nuno Teixeira <<a href=3D"mailto:eduardo@free=
bsd.org" target=3D"_blank">eduardo@freebsd.org</a>> wrote:<br>
> <br>
> main 1400093 aarch64<br>
> <br>
> Anyone seeing www/node18 failing (needed for www/firefox)?<br>
> I tried reverting latest 2 committs and same result with 18.16.0.<br>
> <br>
> Any hints?<br>
> <br>
> <a href=3D"https://people.freebsd.org/~eduardo/logs/node18/node18-18.1=
6.1.log" rel=3D"noreferrer" target=3D"_blank">https://people.freebsd.org/~e=
duardo/logs/node18/node18-18.16.1.log</a><br>
> <a href=3D"https://people.freebsd.org/~eduardo/logs/node18/node18-18.1=
6.0.log" rel=3D"noreferrer" target=3D"_blank">https://people.freebsd.org/~e=
duardo/logs/node18/node18-18.16.0.log</a><br>
<br>
These are similar to <<a href=3D"https://bugs.freebsd.org/272013" rel=3D=
"noreferrer" target=3D"_blank">https://bugs.freebsd.org/272013</a>>, but=
instead of properly fixing it, the can was kicked down the road in <<a =
href=3D"https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5=
719de82b8dd49950d" rel=3D"noreferrer" target=3D"_blank">https://cgit.freebs=
d.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de82b8dd49950d</a>>.<=
br>
<br>
These enums should be fixed by either removing the values outside of the en=
um's valid range, or by specifying the enum's underlying type expli=
citly to allow for such values. In the near future the -Wno-enum-constexpr-=
conversion flag is going to go away!<br>
<br>
-Dimitry<br>
<br>
</blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ=
er (ports)</span></div></div>
</blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre=
fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l=
tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ=
er (ports)</span></div></div>
--000000000000b7a66b0600a9439d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7U%2BHW%2BeKREA4wwvVjGk%2BtR6FF3hRtQxg6r%2BPDh39Ye3HAw>