Date: Mon, 12 Oct 2020 01:35:29 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: ports-committers@freebsd.org, gnome <gnome@freebsd.org> Subject: Re: svn commit: r552054 - head/x11/gnome-shell Message-ID: <262f6c4b-30df-e5b4-99d3-393951c5cacd@FreeBSD.org> In-Reply-To: <20201011210939.GB55792@elch.exwg.net> References: <202010111146.09BBkHW0018750@repo.freebsd.org> <20201011203426.GA55792@elch.exwg.net> <8359bb8b-6276-749b-9807-58488f1b65cb@FreeBSD.org> <20201011210939.GB55792@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 11.10.20 um 23:09 schrieb Christoph Moench-Tegeder:
>
> Hi,
>
> ## Matthias Andree (mandree@FreeBSD.org):
>
>> So let's take a spade and dig. There is
>> work/gnome-shell-3.36.6/subprojects/extensions-tool/meson.build
>>
>> which has
>>
>>> bash_completion = dependency('bash-completion', required: get_option('bash_completion'))
>
> So it's gnome-shell which needs a dependency on bash-completion.
> We shouldn't (must not?) rely on other ports to pull in our
> dependencies.
>
>> So unless you are building p11-kit or gnome-control-center with
>> non-default options,
>
> p11-kit it is (looks like the BASH option there caused me some trouble some
> time ago - don't know what, but it was late and I was angry, according to
> git).
>
>> Can it hurt to always include the configuration file? We're talking less
>> than 2 kB out of 9 MB flat size.
>
> When installing gnome, that one file doesn't matter.
> But we should get the dependencies right.
I am not sure if it is a hard dependency. gnome-shell will work without
bash completions for the extension manager, so it's more like a
requisite to cheat meson for gnome-shell, i. e. BUILD_DEPENDS.
Do we want bash-completion also as a run-time dependency? If so, it's a
more consistent experience at the expense of two more direct requisites
packages (bash-completion, bash).
Any other good reasons to decide about the RUN_DEPENDS, either way?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?262f6c4b-30df-e5b4-99d3-393951c5cacd>