Date: Fri, 30 Mar 2012 15:55:31 -0400 From: Michael Scheidell <scheidell@FreeBSD.org> To: <freebsd-ports@freebsd.org> Subject: Re: FAQ on PORTREVISION bump? Message-ID: <4F760FB3.6020708@FreeBSD.org> In-Reply-To: <4F75FA31.2030806@p6m7g8.com> References: <4F732C89.3040804@FreeBSD.org> <CADLo838kts0QhA1Rvf=S-GCZK2quyfmUdJHUqn6J2-31F9aWXQ@mail.gmail.com> <4F733432.4020902@FreeBSD.org> <63ca1b333a310ecc2b1d1f0e1e1542a1.squirrel@mail.experts-exchange.com> <4F7338C3.8020003@p6m7g8.com> <4F733C3A.7020004@missouri.edu> <4F734524.2000400@p6m7g8.com> <4F735340.1020103@FreeBSD.org> <4F7379FD.9040802@p6m7g8.com> <20120329200243.GA76833@server.vk2pj.dyndns.org> <20120330131625.GA30070@atarininja.org> <4F75F3ED.9000508@p6m7g8.com> <4F75FA31.2030806@p6m7g8.com>
next in thread | previous in thread | raw e-mail | index | archive | help
So, lets start:
Am I the only one that finds he is too stupid to actually figure this
out? I think it is still the most confusing aspect of
committing/maintaining.
When to bump PORTREVISION:
* If you think the end user needs to rebuild the port.
When not to bump PORTREVION:
* If you think its a noop/waste of time/cpu for the end user to
rebuild the port.
Ok, flesh this out:
examples
When to bump PORTREVISION (when you want end user to build the port)
* Mandatory:
o When package changes (make package)
o When dependencies change (Adding USE_PERL/BUILD_PERL/GETTEXT
counts)
o When pkg-plist changes (except for fixing
.ifdef/NOPORT(DOCS|EXAMPLES))
o When the master port changes
o When PORTVERSION CHANGES (must change back to 0, delete line)
o When you want to force a relink with an updated (fixed) library
o If a patch fixes something in the port
o If you add new functionality
o If you add/delete an OPTION
o If you change the default for an OPTION
* port committers have authority to bump PORTREVISION maintainer
(implicit) if the master port/library port/dependency port
requires any dependency to fit the list above.
when NOT to
* just fixing .ifdef/NOPORT(DOCS|EXAMPLES))
* if port was broken on any arch. (rebuilding on existing arch is a
noop, and fixed arch didn't package anyway)
* Fixing typo's in pkg-message, Comment
* Updating port maintainer (new one or resetting port maintainer)
* just petting portlint (<space> after name to <tab>), re-order sections
(notice I left out pointyhat.. if it is overworked, lets send more hardware)
--
Michael Scheidell, CTO
>*| * SECNAP Network Security Corporation
d: +1.561.948.2259
w: http://people.freebsd.org/~scheidell
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F760FB3.6020708>