From owner-cvs-usrbin Sun Jul 14 11:05:44 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id LAA18277 for cvs-usrbin-outgoing; Sun, 14 Jul 1996 11:05:44 -0700 (PDT) Received: from lestat.nas.nasa.gov (lestat.nas.nasa.gov [129.99.50.29]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id LAA18270; Sun, 14 Jul 1996 11:05:42 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lestat.nas.nasa.gov (8.7.5/8.6.12) with SMTP id KAA29768; Sun, 14 Jul 1996 10:58:43 -0700 (PDT) Message-Id: <199607141758.KAA29768@lestat.nas.nasa.gov> X-Authentication-Warning: lestat.nas.nasa.gov: Host localhost [127.0.0.1] didn't use HELO protocol To: Paul Traina Cc: Wolfram Schneider , Nate Williams , CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org Subject: Re: cvs commit: src/usr.bin/rdist defs.h docmd.c expand.c lookup.c server.c Reply-To: Jason Thorpe From: Jason Thorpe Date: Sun, 14 Jul 1996 10:58:42 -0700 Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Sun, 14 Jul 1996 10:22:32 -0700 Paul Traina wrote: > That's way over-board. The only case where sprintf can get you into trouble > is if you're sprintfing tainted variables (to steal a perl term) into a stack > buffer. It may be overboard, but it certainly doesn't _hurt_ :-) > Should we disable sprintf() for sgid/suid programs? > > find /bin /usr/bin /sbin /usr/sbin /usr/libexec -perm -u+s \ > -o -perm -g+s |xargs egrep -l sprintf | wc -l > > 47 Not that many, and it's probably worth it. We're thinking of doing that in the NetBSD camp, too. I'd say that for the relatively small amount of work that it would take to sweep-up, the quality added to one's sleep makes the choice clear :-) -- save the ancient forests - http://www.bayarea.net/~thorpej/forest/ -- Jason R. Thorpe thorpej@nas.nasa.gov NASA Ames Research Center Home: 408.866.1912 NAS: M/S 258-6 Work: 415.604.0935 Moffett Field, CA 94035 Pager: 415.428.6939