Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 May 2021 07:13:27 GMT
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: c210d2ab69b6 - main - Mk/Uses/readline.mk: Remove unnecessary 'port' argument
Message-ID:  <202105150713.14F7DRS7000338@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by tobik:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c210d2ab69b612d5b7974a34d267be027039b827

commit c210d2ab69b612d5b7974a34d267be027039b827
Author:     Yasuhiro Kimura <yasu@utahime.org>
AuthorDate: 2021-05-15 06:51:40 +0000
Commit:     Tobias Kortkamp <tobik@FreeBSD.org>
CommitDate: 2021-05-15 07:14:05 +0000

    Mk/Uses/readline.mk: Remove unnecessary 'port' argument
    
    Currently no supported FreeBSD version has libreadline.so in base.
    Then if 'USES=readline' is used devel/readline is always added to
    dependency whether or not 'port' argument is specified.  So remove
    unnecessary 'port' argument now.
    
    PR:             248459
    Exp-run by:     antoine
---
 Mk/Uses/readline.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/Mk/Uses/readline.mk b/Mk/Uses/readline.mk
index c56cca74db5d..4893ebfdee6b 100644
--- a/Mk/Uses/readline.mk
+++ b/Mk/Uses/readline.mk
@@ -2,21 +2,18 @@
 #
 # Feature:	readline
 # Usage:	USES=readline
-# Valid ARGS:	port
 #
 # MAINTAINER: portmgr@FreeBSD.org
 
 .if !defined(_INCLUDE_USES_READLINE_MK)
 _INCLUDE_USES_READLINE_MK=	yes
 
-.if !exists(/usr/lib/libreadline.so)
-readline_ARGS=	port
+.if !empty(readline_ARGS)
+IGNORE= Incorrect 'USES+= readline:${readline_ARGS}' readline takes no arguments
 .endif
 
-.if ${readline_ARGS} == port
 LIB_DEPENDS+=		libreadline.so.8:devel/readline
 CPPFLAGS+=		-I${LOCALBASE}/include
 LDFLAGS+=		-L${LOCALBASE}/lib
-.endif
 
 .endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105150713.14F7DRS7000338>