From owner-freebsd-ports@FreeBSD.ORG Sat Aug 5 08:54:58 2006 Return-Path: X-Original-To: ports@FreeBSD.ORG Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 646C216A4DE; Sat, 5 Aug 2006 08:54:58 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.FreeBSD.org (Postfix) with ESMTP id 549F643D45; Sat, 5 Aug 2006 08:54:56 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.7/8.13.7) with ESMTP id k758stda046235; Sat, 5 Aug 2006 12:54:55 +0400 (MSD) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.7/8.13.7/Submit) id k758stEP046234; Sat, 5 Aug 2006 12:54:55 +0400 (MSD) (envelope-from ache) Date: Sat, 5 Aug 2006 12:54:55 +0400 From: Andrey Chernov To: G?bor K?vesd?n Message-ID: <20060805085455.GA46190@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , G?bor K?vesd?n , Edwin Groothuis , ports@FreeBSD.ORG References: <44D370E9.1080209@FreeBSD.org> <20060805070336.GA997@k7.mavetju> <44D45B87.5060601@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44D45B87.5060601@FreeBSD.org> User-Agent: Mutt/1.5.12-2006-07-14 Cc: ports@FreeBSD.ORG, Edwin Groothuis Subject: Re: HEADS-UP: DESTDIR support committed to Mk/ X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Aug 2006 08:54:58 -0000 On Sat, Aug 05, 2006 at 10:49:11AM +0200, G?bor K?vesd?n wrote: > Edwin Groothuis wrote: > >On Fri, Aug 04, 2006 at 06:08:09PM +0200, G?bor K?vesd?n wrote: > > > >>I am pleased to announce, that portmgr committed my patch for ports > >>infrastructure DESTDIR support today. Note that this support is only for > >>the infrastructure, ports may or may not respect the DESTDIR macro, so > >> > > > >Having read the wiki, please let me ask a couple of questions to > >make sure there is consensus on what needs to be done to make all > >ports DESTDIR happy. > > > >- All ports Makefiles should be checked for installs into PREFIX, > > and replaced by TARGETDIR (or DESTDIR/PREFIX) > > > Yes, TARGETDIR resolves to DESTDIR/PREFIX, which should be the final > destination. In many ports we have a do-install or post-install target > with something like: > > @${INSTALL_PROGRAM} ${WRKSRC}/foo ${PREFIX}/bin > > This is definitely not good, since it will install to ${PREFIX} even if > you set DESTDIR, so this needs a s/${PREFIX}/${TARGETDIR}/. It will be much better to not change that in almost in every port, but change meaning of PREFIX instead: PREFIX == DESTDIR/DESTPREFIX -- http://ache.pp.ru/