From owner-svn-src-all@FreeBSD.ORG Mon Jan 4 19:24:25 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49B1E1065692; Mon, 4 Jan 2010 19:24:25 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) by mx1.freebsd.org (Postfix) with ESMTP id AA2918FC0A; Mon, 4 Jan 2010 19:24:24 +0000 (UTC) Received: from [192.168.1.190] (p508FF7CB.dip.t-dialin.net [80.143.247.203]) by mail-n.franken.de (Postfix) with ESMTP id 8628D1C0C0BEA; Mon, 4 Jan 2010 20:24:22 +0100 (CET) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Michael Tuexen In-Reply-To: <20100104190024.GA47532@onelab2.iet.unipi.it> Date: Mon, 4 Jan 2010 20:24:21 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <517EF225-7EEB-4844-A0AD-019AD72F9403@freebsd.org> References: <201001041825.o04IPcXb043347@svn.freebsd.org> <20100104190024.GA47532@onelab2.iet.unipi.it> To: Luigi Rizzo X-Mailer: Apple Mail (2.1077) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: moving sctp to a separate directory ? (Re: svn commit: r201523 - head/sys/netinet) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 19:24:25 -0000 On Jan 4, 2010, at 8:00 PM, Luigi Rizzo wrote: > taking a random commit to this tree -- would you guys consider moving > the sctp sources to its own directory, e.g. netinet/sctp/ or something > that suits better ? Why do you think that a place different from netinet/ does suit better for the sctp_*.[ch] files than netinet/ ? This is at least the place where TCP and UDP live... Best regards Michael >=20 > It would help to browse through the directory: >=20 > NAME FILES LINES >=20 > netinet/ 156 153k > sctp* 36 66k > tcp* 24 16k > ipfw/ 9 9k >=20 >=20 > I understand that some of the headers should remain in netinet/ > but surely the code is not bound to a specific place... >=20 > cheers > luigi >=20 > On Mon, Jan 04, 2010 at 06:25:38PM +0000, Michael Tuexen wrote: >> Author: tuexen >> Date: Mon Jan 4 18:25:38 2010 >> New Revision: 201523 >> URL: http://svn.freebsd.org/changeset/base/201523 >>=20 >> Log: >> Correct usage of parenthesis. >>=20 >> PR: kern/142066 >> Approved by: rrs (mentor) >> Obtained from: Henning Petersen, Bruce Cran. >> MFC after: 2 weeks >>=20 >> Modified: >> head/sys/netinet/sctp_pcb.c >>=20 >> Modified: head/sys/netinet/sctp_pcb.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/sctp_pcb.c Mon Jan 4 18:21:27 2010 = (r201522) >> +++ head/sys/netinet/sctp_pcb.c Mon Jan 4 18:25:38 2010 = (r201523) >> @@ -5528,7 +5528,7 @@ sctp_pcb_init() >>=20 >> /* Init the TIMEWAIT list */ >> for (i =3D 0; i < SCTP_STACK_VTAG_HASH_SIZE; i++) { >> - LIST_INIT(&SCTP_BASE_INFO(vtag_timewait[i])); >> + LIST_INIT(&SCTP_BASE_INFO(vtag_timewait)[i]); >> } >>=20 >> #if defined(SCTP_USE_THREAD_BASED_ITERATOR) >> @@ -6385,7 +6385,7 @@ sctp_is_vtag_good(struct sctp_inpcb *inp >> } >> skip_vtag_check: >>=20 >> - chain =3D &SCTP_BASE_INFO(vtag_timewait[(tag % = SCTP_STACK_VTAG_HASH_SIZE))]; >> + chain =3D &SCTP_BASE_INFO(vtag_timewait)[(tag % = SCTP_STACK_VTAG_HASH_SIZE)]; >> /* Now what about timed wait ? */ >> if (!LIST_EMPTY(chain)) { >> /* >=20