From owner-cvs-all@FreeBSD.ORG Wed Oct 25 15:04:13 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B9A216A4A7; Wed, 25 Oct 2006 15:04:13 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3BA1F43D72; Wed, 25 Oct 2006 15:03:52 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9PF3hTs018720; Wed, 25 Oct 2006 11:03:44 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Wed, 25 Oct 2006 10:48:56 -0400 User-Agent: KMail/1.9.1 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610241430.12149.jhb@freebsd.org> <200610250654.11455.davidxu@freebsd.org> In-Reply-To: <200610250654.11455.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610251048.57097.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 25 Oct 2006 11:03:44 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2098/Wed Oct 25 09:14:20 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2006 15:04:13 -0000 On Tuesday 24 October 2006 18:54, David Xu wrote: > On Wednesday 25 October 2006 02:30, John Baldwin wrote: > > On Monday 23 October 2006 18:47, David Xu wrote: > > > On Monday 23 October 2006 23:33, John Baldwin wrote: > > > > On Saturday 21 October 2006 19:59, David Xu wrote: > > > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > sys/kern kern_exit.c > > > > > Log: > > > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the > > > > > change opened a race window which can cause memory leak in signal > > > > > queue. Here we free memory for signal queue when process state is set > > > > > to PRS_ZOMBIE. > > > > > > > > Is there any reason to not just harvest it in wait() instead? > > > > > > I prefer to free it earlier rather than delaying it if I can. > > > > But we already do the free'ing "later" (wait() really isnt' all that later > > than exit1() for most processes) for sigacts, limits, etc. It would seem > > that sigqueue and sigacts would have nearly identical lifetimes. > > But if system is under heavily memory loaded, doesn't freeing it earlier make > it better ? sigqueue does not have safe lifetime as sigacts, every thread > has it, we check signal queue leak in thread_exit(), if you move the > sigqueue_flush into wait1, then that code also has to be adjusted, > because now not every thread will free the memory when it is exited, > they no long have consistent behavior. If it works as it is now, then it is fine. Forgot that sigqueue was per-thread rather than per-process. -- John Baldwin