Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Apr 2018 14:01:10 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r332030 - stable/11/sys/dev/efidev
Message-ID:  <201804041401.w34E1ASS016260@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Wed Apr  4 14:01:10 2018
New Revision: 332030
URL: https://svnweb.freebsd.org/changeset/base/332030

Log:
  MFC r331413: efidev: Drop a quick note in about efi_cfgtbl/efi_runtime
  
  There's no real annotation for it, so it's not immediately obvious to the
  unfamiliar that these pointers are to locations in the EFI runtime map
  unlike the system table pointer immediately above them.

Modified:
  stable/11/sys/dev/efidev/efirt.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/dev/efidev/efirt.c
==============================================================================
--- stable/11/sys/dev/efidev/efirt.c	Wed Apr  4 13:59:42 2018	(r332029)
+++ stable/11/sys/dev/efidev/efirt.c	Wed Apr  4 14:01:10 2018	(r332030)
@@ -57,6 +57,11 @@ __FBSDID("$FreeBSD$");
 #include <vm/vm_map.h>
 
 static struct efi_systbl *efi_systbl;
+/*
+ * The following pointers point to tables in the EFI runtime service data pages.
+ * Care should be taken to make sure that we've properly entered the EFI runtime
+ * environment (efi_enter()) before dereferencing them.
+ */
 static struct efi_cfgtbl *efi_cfgtbl;
 static struct efi_rt *efi_runtime;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804041401.w34E1ASS016260>