From owner-cvs-src@FreeBSD.ORG Tue Jan 20 19:44:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C226016A4CE; Tue, 20 Jan 2004 19:44:04 -0800 (PST) Received: from kientzle.com (h-66-166-149-50.SNVACAID.covad.net [66.166.149.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4151B43D41; Tue, 20 Jan 2004 19:44:03 -0800 (PST) (envelope-from kientzle@acm.org) Received: from acm.org ([66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id i0L3i1kX008431; Tue, 20 Jan 2004 19:44:02 -0800 (PST) (envelope-from kientzle@acm.org) Message-ID: <400DF580.2040404@acm.org> Date: Tue, 20 Jan 2004 19:44:00 -0800 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.4) Gecko/20031006 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Bruce Evans References: <20040120182929.4573C16A4CF@hub.freebsd.org> <20040121123903.W6693@gamplex.bde.org> In-Reply-To: <20040121123903.W6693@gamplex.bde.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Bill Paul cc: src-committers@FreeBSD.org cc: phk@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: kientzle@acm.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2004 03:44:04 -0000 On Tue, 20 Jan 2004, Bill Paul wrote: > >Anyway, to reiterate: I don't think the lineno/sourcefile additions >to panic() are worth the bloat. I think the lineno/sourcefile additions are very valuable, but for a reason that noone has so far mentioned: Grooming new developers. In short, I think a wannabe kernel hacker is much more likely to dive in and try to understand a problem if you give them some rough guidance about where to start looking. For someone who doesn't already know the codebase, that means a source file and line number, not a function name or panic string that requires them to search the entire codebase. Sure, lineno/filename doesn't help with all kinds of panics, and it's not as good as having every kernel panic immediately open a remote GDB window over the Internet directly on the appropriate developer's desktop. But if it engages the interest of a couple of future FreeBSD developers, then it is worth a lot more than 32k of data space. I would like for tracebacks to have sourcefile/lineno information for the same reason, but that's an awful lot more bloat than Poul-Henning's quite modest proposal. Tim