From owner-p4-projects@FreeBSD.ORG  Thu Sep 13 19:52:16 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4E37F16A498; Thu, 13 Sep 2007 19:52:16 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0913916A419
	for <perforce@FreeBSD.org>; Thu, 13 Sep 2007 19:52:16 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E30B613C458
	for <perforce@FreeBSD.org>; Thu, 13 Sep 2007 19:52:15 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8DJqFHl049312
	for <perforce@FreeBSD.org>; Thu, 13 Sep 2007 19:52:15 GMT
	(envelope-from cnst@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8DJqF7S049309
	for perforce@freebsd.org; Thu, 13 Sep 2007 19:52:15 GMT
	(envelope-from cnst@FreeBSD.org)
Date: Thu, 13 Sep 2007 19:52:15 GMT
Message-Id: <200709131952.l8DJqF7S049309@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	cnst@FreeBSD.org using -f
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 126374 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Sep 2007 19:52:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=126374

Change 126374 by cnst@dale on 2007/09/13 19:51:24

	the invalid flag usually means all fields are invalid,
	not just the value field

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sbin.sysctl/sysctl.c#10 (text+ko) ====

@@ -418,14 +418,17 @@
 		return (1);
 	}
 
-	if (s->flags & SENSOR_FINVALID)
+	if (s->flags & SENSOR_FINVALID) {
 		/*
 		 * XXX: with this flag, the node should be entirely ignored,
 		 * but as the magic-based sysctl(8) is not too flexible, we
 		 * simply have to print out that the sensor is invalid.
 		 */
 		printf("invalid");
-	else if (s->flags & SENSOR_FUNKNOWN)
+		return (0);
+	}
+
+	if (s->flags & SENSOR_FUNKNOWN)
 		printf("unknown");
 	else {
 		switch (s->type) {