From owner-cvs-src@FreeBSD.ORG Thu May 25 11:10:40 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE8E616A422; Thu, 25 May 2006 11:10:40 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id C297643D55; Thu, 25 May 2006 11:10:39 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k4PBAaCt036499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 25 May 2006 15:10:36 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k4PBAZka036498; Thu, 25 May 2006 15:10:35 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 25 May 2006 15:10:35 +0400 From: Gleb Smirnoff To: Warner Losh Message-ID: <20060525111035.GI27819@FreeBSD.org> References: <200605241726.k4OHQG59037586@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <200605241726.k4OHQG59037586@repoman.freebsd.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2006 11:10:40 -0000 On Wed, May 24, 2006 at 05:26:16PM +0000, Warner Losh wrote: W> imp 2006-05-24 17:26:16 UTC W> W> FreeBSD src repository W> W> Modified files: W> sys/dev/pccbb pccbb.c W> Log: W> Suspend the children before we turn off card events in hardware. This W> was done, I believe, to work around some cards having issues in the W> suspend case. I think that this helped my Sony VAIO TS505 work better W> when it had certain wireless cards in it and I did a apm -z. I've not ^^^^^^^ W> tested suspend/resume on other laptops in a long time, so I hope this ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ W> doesn't cause greif. Please let me know if it does. ^^^^^^^^^^^^^^^^^^^ Is this a joke, that I can't understand? :( This file has broken APM suspend since revision 1.122, which was made almost a year ago. I've told that several times, and I still hope that this will be fixed before RELENG_7. The problem is not in suspending children, since suspend is broken w/o any cards in slot. The problem is in DELAY -> tsleep() conversion. The latter is not working, when system is suspending. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE