From owner-freebsd-current@FreeBSD.ORG Thu Apr 24 11:13:23 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A0121065670; Thu, 24 Apr 2008 11:13:23 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [91.103.162.4]) by mx1.freebsd.org (Postfix) with ESMTP id 1975D8FC1D; Thu, 24 Apr 2008 11:13:23 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from localhost (localhost.codelab.cz [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id C42ED19E023; Thu, 24 Apr 2008 12:53:30 +0200 (CEST) Received: from [192.168.1.2] (r5bb235.net.upc.cz [86.49.61.235]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 9B2B219E019; Thu, 24 Apr 2008 12:53:28 +0200 (CEST) Message-ID: <481066BA.1050703@quip.cz> Date: Thu, 24 Apr 2008 12:53:46 +0200 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.12) Gecko/20050915 X-Accept-Language: cz, cs, en, en-us MIME-Version: 1.0 To: Clement Laforet References: <8481.1208889581@critter.freebsd.dk> <480E3E66.3000303@samsco.org> <20080423141929.GA61109@goofy.cultdeadsheep.org> In-Reply-To: <20080423141929.GA61109@goofy.cultdeadsheep.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org, Ivan Voras Subject: Re: Http Accept filters (accf_http) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2008 11:13:23 -0000 Clement Laforet wrote: > On Tue, Apr 22, 2008 at 10:34:14PM +0200, Ivan Voras wrote: > >>Scott Long wrote: [...] >>Does anyone know why accf_accept is disabled by default in the ports' >>stock Apache 2.2 (it's disabled in the default config files)? I thought >>it was because it was dangerous or flawed for some reason, though (at >>least for light loads comparable to those of OP) it seems to work fine. > > > There's not technical reason actually. It's an "opt-in" feature ;-) > In the early 2.2.x times, httpd used to print a warning when accf_http > is disabled. It was, of course, just a matter of loglevel. apache ran > perfectly fine, but a warning got printed. Some users started > complaining about how my port was broken, sometimes in very rude > manner. > So I decided to explicilty disable AcceptFilter unless > apache22_http_accept_enable is set to "YES" in /etc/rc.conf. There is another one "problem" with accf_*. Even if modules are loaded, apache on graceful restart prints warning: [Tue Apr 22 02:22:09 2008] [notice] Graceful restart requested, doing restart [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter [Tue Apr 22 02:22:09 2008] [warn] (22)Invalid argument: Failed to enable the 'httpready' Accept Filter It is known problem for a long time (as I am seeing it few years). Plain start works without warnings. I have apache controlled by daemontools with run script: exec /usr/local/sbin/httpd -D NO_DETACH -D SSL 2>> /var/log/httpd-error.log Graceful restart done by: kill -USR1 `cat /var/run/httpd.pid` apache-2.2.8 on FreeBSD 7.0-RELEASE i386 GENERIC Miroslav Lachman PS: https://issues.apache.org/bugzilla/show_bug.cgi?id=37863