From owner-cvs-src@FreeBSD.ORG  Mon Feb 14 16:04:24 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 22DA416A4CE; Mon, 14 Feb 2005 16:04:24 +0000 (GMT)
Received: from phantom.cris.net (phantom.cris.net [212.110.130.74])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id DA32F43D4C; Mon, 14 Feb 2005 16:04:22 +0000 (GMT)
	(envelope-from phantom@FreeBSD.org.ua)
Received: from phantom.cris.net (phantom@localhost [127.0.0.1])
	by phantom.cris.net (8.12.10/8.12.10) with ESMTP id j1EG8cf4001493;
	Mon, 14 Feb 2005 18:08:38 +0200 (EET)
	(envelope-from phantom@FreeBSD.org.ua)
Received: (from phantom@localhost)
	by phantom.cris.net (8.12.10/8.12.10/Submit) id j1EG8cgl001492;
	Mon, 14 Feb 2005 18:08:38 +0200 (EET)
	(envelope-from phantom)
Date: Mon, 14 Feb 2005 18:08:38 +0200
From: Alexey Zelkin <phantom@FreeBSD.org.ua>
To: Hajimu UMEMOTO <ume@FreeBSD.org>
Message-ID: <20050214160838.GA1414@phantom.cris.net>
References: <200502141133.j1EBXC6D001449@repoman.freebsd.org>
	<ygeu0of5e4z.wl%ume@mahoroba.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ygeu0of5e4z.wl%ume@mahoroba.org>
X-Operating-System: FreeBSD 4.9-STABLE i386
User-Agent: Mutt/1.5.5.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Feb 2005 16:04:24 -0000

On Tue, Feb 15, 2005 at 12:56:28AM +0900, Hajimu UMEMOTO wrote:
> Hi,
> 
> >>>>> On Mon, 14 Feb 2005 11:33:12 +0000 (UTC)
> >>>>> Alexey Zelkin <phantom@FreeBSD.org> said:
> 
> phantom>   . Convert ai_errlist[] to simple 'char *' array, and appropriately
> phantom>     optimize gai_strerror()
> 
> Why did you do this?  Since this departs from KAME's getaddrinfo.c, I
> don't want this change unless there is meaningful advantage.

1. This is optimization.
2. This is preparation to addition of NLS support for gai_strerror()

Actually, since gai_strerror() is exported function and only user
of ai_errlist[], would not it be better to move these to separate
source file ?  It will make KAME integration for getaddrinfo.c
much easier, IMHO.

-- 
/* Alexey Zelkin             && Independent Contractor      */
/* phantom(at)FreeBSD.org    && http://www.FreeBSD.org/java */
/* phantom(at)cris.net       && http://www.FreeBSD.org.ua/  */