From owner-freebsd-current Tue Jan 25 6:30:49 2000 Delivered-To: freebsd-current@freebsd.org Received: from darkstar.qx.net (darkstar.qx.net [208.235.88.101]) by hub.freebsd.org (Postfix) with ESMTP id 7021B155EB for ; Tue, 25 Jan 2000 06:30:40 -0800 (PST) (envelope-from gchil0@pop.uky.edu) Received: from mail.qx.net (mail.qx.net [208.235.88.10]) by darkstar.qx.net (8.8.7/8.8.7) with ESMTP id JAA25145 for ; Tue, 25 Jan 2000 09:30:38 -0500 Received: from k7 ([207.246.86.12]) by mail.qx.net (Netscape Messaging Server 3.6) with ESMTP id AAA3E9C; Tue, 25 Jan 2000 09:33:27 -0500 Message-Id: <4.2.0.58.20000125092146.00961dc0@pop.uky.edu> X-Sender: gchil0@pop.uky.edu X-Mailer: QUALCOMM Windows Eudora Pro Version 4.2.0.58 Date: Tue, 25 Jan 2000 09:32:03 -0500 To: Soren Schmidt From: Greg Childers Subject: Re: 4.0 CODE FREEZE WILL BEGIN IN FIVE (5) DAYS Cc: current@freebsd.org In-Reply-To: <200001250719.IAA61546@freebsd.dk> References: <4.2.0.58.20000124185659.0095acb0@pop.uky.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 08:19 AM 1/25/00 +0100, Soren Schmidt wrote: > > On some older PCI systems, including my Pentium 66, the driver still= detects > > irq 0 for ata-pci0. Hardwiring it to irq 14 in the source as suggested= recently is the >temporary fix I'm using.=20 > >Could you send that patch around me please ? > >-S=F8ren The quick fix I'm using is at the end of this email. The irq was correctly= detected before the following commit: sos 1999/10/09 12:57:15 PDT Modified files: sys/dev/ata ata-all.c ata-all.h ata-disk.c ata-disk.h=20 ata-dma.c atapi-all.c atapi-all.h=20 atapi-cd.c atapi-fd.c atapi-fd.h=20 atapi-tape.c atapi-tape.h=20 Log: Add support for the HPT366 chip, this is used on the Abit boards and their HotRod controller and on SIIG PCI ultra DMA controller. These changes also made lots of the Promise code go away, its all much more generic this way. =20 Get rid of atapi_immed_cmd, instead use the queue to move atapi commands from interrupt context if nessesary, the entire atapi layer has gotten an overhaul. =20 Lots of fixes to utililize the new features in subr_disk.c etc, and get rid of the last biots of softc arrays in the drivers, the only one left is atadevices which cannot easily go away (yet). =20 Use our own malloc names, its a lot easier to track memory usage this= way. =20 General cleanup overall. Hope this helps! Greg --- ata-all.c.orig Sun Jan 16 17:08:59 2000 +++ ata-all.c Sun Jan 16 17:09:30 2000 @@ -291,6 +291,11 @@ iobase_1 =3D pci_read_config(dev, 0x10, 4) & IOMASK; altiobase_1 =3D pci_read_config(dev, 0x14, 4) & IOMASK; irq1 =3D pci_read_config(dev, PCI_INTERRUPT_REG, 4) & 0xff; + if (irq1 !=3D 14) { + printf("Detected irq: %d ", irq1); + printf("Changing to 14!!\n"); + irq1 =3D 14; + } } =20 if (pci_get_progif(dev) & PCIP_STORAGE_IDE_MASTERDEV) { To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message