From owner-cvs-src-old@FreeBSD.ORG Sat Feb 27 05:41:49 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CB041065785 for ; Sat, 27 Feb 2010 05:41:49 +0000 (UTC) (envelope-from mjacob@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 5F72A8FC13 for ; Sat, 27 Feb 2010 05:41:49 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o1R5fnWH096209 for ; Sat, 27 Feb 2010 05:41:49 GMT (envelope-from mjacob@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o1R5fnd2096208 for cvs-src-old@freebsd.org; Sat, 27 Feb 2010 05:41:49 GMT (envelope-from mjacob@repoman.freebsd.org) Message-Id: <201002270541.o1R5fnd2096208@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to mjacob@repoman.freebsd.org using -f From: Matt Jacob Date: Sat, 27 Feb 2010 05:41:23 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/isp isp.c isp_freebsd.c isp_library.c isp_library.h isp_pci.c isp_target.c ispmbox.h ispreg.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2010 05:41:49 -0000 mjacob 2010-02-27 05:41:23 UTC FreeBSD src repository Modified files: sys/dev/isp isp.c isp_freebsd.c isp_library.c isp_library.h isp_pci.c isp_target.c ispmbox.h ispreg.h Log: SVN rev 204397 on 2010-02-27 05:41:23Z by mjacob Revamp the pieces of some of the stuff I forgot to do when shifting to 32 bit handles. The RIO (reduced interrupt operation) and fast posting for the parallel SCSI cards were all 16 bit handles. Furthermore, target mode parallel SCSI only can have 16 bit handles. Use part of a supplied patch to switch over to using 32 bit handles. Be a bit more conservative here and only do this for parallel SCSI for the 12160 (Ultra3) cards. There were a lot of marginal Ultra2 cards, and, frankly, few are findable now for testing. Fix the target handle routine to only do 16 bit handles for parallel SCSI cards. This is okay because the upper sixteen bits of the new 32 bit handles is a sequence number to help protect against duplicate completions. This would be very unlikely to happen with parallel SCSI target mode, and wasn't present before, so we're no worse off than we used to be. While we're at it, finally split the async mailbox completion handlers into FC and parallel SCSI functions. This makes it much cleaner and easier to figure out what is or isn't a legal async mailbox completion code for different card classes. PR: kern/144250 Submitted partially by: Charles D MFC after: 1 week Revision Changes Path 1.161 +180 -216 src/sys/dev/isp/isp.c 1.157 +2 -1 src/sys/dev/isp/isp_freebsd.c 1.20 +30 -5 src/sys/dev/isp/isp_library.c 1.11 +1 -0 src/sys/dev/isp/isp_library.h 1.152 +6 -12 src/sys/dev/isp/isp_pci.c 1.47 +3 -1 src/sys/dev/isp/isp_target.c 1.64 +10 -8 src/sys/dev/isp/ispmbox.h 1.31 +2 -2 src/sys/dev/isp/ispreg.h