From owner-cvs-all Sat Sep 18 15:10:54 1999 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 2A73714FE7; Sat, 18 Sep 1999 15:10:49 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.2) with ESMTP id AAA13146; Sun, 19 Sep 1999 00:10:36 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vn vn.c In-reply-to: Your message of "Sat, 18 Sep 1999 15:02:39 PDT." Date: Sun, 19 Sep 1999 00:10:36 +0200 Message-ID: <13144.937692636@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message , Julian Elischer writes: >Poul-Henning, since Matt (who is working on this driver) STATED that he >didn't want you to do this, why did you do it anyway? Uhm, I read your last message as your approval for this... >If you want to do this right.. > >Move the calculation of blocksize in spec_read and spec_write >to spec_open, and store the value in to si_bsize_best if it's still unset, >and then in read/write just blindly use _best, instead of doing the >calculation on every read and write. I think si_bsize_best should not even be used in spec_read/_write. I think they should blindly use max(PAGE_SIZE, si_bsize_phys). -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message