From owner-freebsd-current@freebsd.org Tue Jun 28 16:22:43 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42295B85306; Tue, 28 Jun 2016 16:22:43 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D5C922B38; Tue, 28 Jun 2016 16:22:42 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id a66so35587074wme.0; Tue, 28 Jun 2016 09:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Wfm9SQter/9xI4CZpVW0sTS0Ow3/UjDqlGBixQDKYP0=; b=KC+S2bDOFtLohiTkxyJ022Q+B7ggsBchhef2cG21LUsmk8O21fpwaSitKe8Bz0f8hl Qd32sEz+LZ+LA3S3UtVNw97567lfaRH24UYUUYJjeAyw0p4moX6E3myQEDlMx7YdOI+6 JL7aJHVDL3zfDihb+yPhunL1ZJQZBRWTxu94kIegVcgNIHuZAfAhPJu0lOqrSkeMakZ6 wFx3nWpRtbqLyci7Ge/RMgZcPuP3cflQcXCJ27inrT9z399mqXtR6h+t59dWMAoicE3d IrIm9wjGFQLtHDQjz+pQsHopHVLmEWdz9ewdE8Mk+y7RvbZCZXESRYh4XDv9TLOluRm8 X9Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=Wfm9SQter/9xI4CZpVW0sTS0Ow3/UjDqlGBixQDKYP0=; b=QupBOZSJ6Ya3k0HqzvOf3GQHpbdc6MZ3hzOjMlYqgG6Abrtc8BC0yut1DE80YzzAwT 0oEn4h0gqhcNFifxoGgQBkawoL130sArd+fbgMGZibufUNnu3O3t/xetdVSFNC//HW1Y RjdOABuXY4WVLj1dyFCh58IWLefDc0Nar71Ry8tT4eHHm4fp/2rrcQecugz6g7jqDA9Z fw3RVH18LipOWr7NLvFKH40cLCD8hG3kwrt9V/4v+KKQQEu3/Gh24oSdESUXAGTFZMnM /Azj/4b8enFXSjAHkyDqn3TTidcqeOkqUU3FU1+gw/988BolUcii2UPzRtbrhoz8WEBT RbxA== X-Gm-Message-State: ALyK8tLJBnQQ6af5X8LzwzkkmK041DjhA5ni/vjCtv8euICQEvttCF//WPvRZ08ZNdzOWQ== X-Received: by 10.194.82.161 with SMTP id j1mr4315510wjy.65.1467130961313; Tue, 28 Jun 2016 09:22:41 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id f73sm3757307wmg.1.2016.06.28.09.22.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 09:22:40 -0700 (PDT) Sender: Baptiste Daroussin Date: Tue, 28 Jun 2016 18:22:39 +0200 From: Baptiste Daroussin To: Hans Petter Selasky Cc: Slawa Olhovchenkov , ports@FreeBSD.org, FreeBSD Current Subject: Re: pkg SAT_SOLVER bugs Message-ID: <20160628162239.nopc2r2mtleuszpm@ivaldir.etoilebsd.net> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5tssyup75cku5k4s" Content-Disposition: inline In-Reply-To: <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 16:22:43 -0000 --5tssyup75cku5k4s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2016 at 05:52:32PM +0200, Hans Petter Selasky wrote: > On 06/27/16 13:55, Baptiste Daroussin wrote: > > On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote: > > > Hi, > > >=20 > > > I found some bugs in PKG with regard to the SAT_SOLVER environment va= riable. > > > Please find patch attached :-) > > >=20 > > > Issues fixed: > > > 1) No need to use hash table when generating SAT rules for external s= olver. > > > Variables are already in a linear array. Fix encoding and decoding of= SAT > > > data. > > > 2) Endless variable loop caused pkg to crash. > > > 3) it->inverse was checked for non-zero, while it should actually be = checked > > > for -1 only. SAT rules produces were all negative. > > >=20 > > > How to verify: > > >=20 > > > make -C /usr/ports/math/picosat all install clean > > >=20 > > > env SAT_SOLVER=3Dpicosat pkg upgrade > > >=20 > > > --HPS > >=20 > > Thank you I will look into shortly > >=20 >=20 > Hi Baptiste, >=20 > Are you handling this one or do you want me to create an issue at github. > Thank you! >=20 I am handling it BTW not that picosat is the one we use internally already :D Best regards Bapt --5tssyup75cku5k4s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcqRPAAoJEGOJi9zxtz5acagQAKZqpdQ5XLmufX2lCsWndnRv WM0aySvnlXJ0+FEmCIHMZBF1xnIupOQA5ZaBFFMcUXFruCuNykEpgSdKVxBP1SA7 VwBoFlQCDolHsA4ItNidGn8SioPdUG+M0ufqEvgOd7vVkT+QJajlYeccBp0Rss3J LQY7t7eBji9jRcHcrMvdXgY28DdPntu72qxypiMc3Vfc5EycR93Nm4ImoKWZMbk/ X+5ph5zM3xM/NwImTOZO13nZfjhmKRR5GGlcgC6QR1c6enaE9ua8LRA4/hbLsyqX 0dVgRXYwmy51+GzNewAQU2Et+9EOCz8CWxcXEk6dgxl6C89YYhrhelEK/or+be0Z NcMgAki5BZfluVekMuOGEzdqm6UMIbq2lsMQBN2HwwUQjMmBMHUcP0J5ahQOOkEp brXalOiTBQwctUqxRXSA4ob+vbALcn8z08TLtq2WjDYnl1E0s3hoHe+PfHgLTbHE e6mj54Nt5KXqMogZKAjT6K6xkDT56vQNndP1RXnfS7wS+7t6K2zZs/k7nzekcjKk b3D27UtxPo4uqsDo4q717GFr84bzgt6uBq1Uz1ZN+Daahw/6MO16TD6M4ZHgIsaT y+nIu7MRsHRI6/n5G56eI72Rk4YCq2Mp2tZeV14qoMWK5Ro54DjLEQeceZIPQK1C cC1VeVVbAaXbFgpwLJO3 =5/Q9 -----END PGP SIGNATURE----- --5tssyup75cku5k4s--