From owner-cvs-src@FreeBSD.ORG Fri Oct 12 21:37:09 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8667E16A469 for ; Fri, 12 Oct 2007 21:37:09 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.189]) by mx1.freebsd.org (Postfix) with ESMTP id 19CE513C448 for ; Fri, 12 Oct 2007 21:37:08 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so856764nfb for ; Fri, 12 Oct 2007 14:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=R+8EzGmvwpNfh51jCPHf4A8QU8QtIhaFWDVHFV1oGsU=; b=F2WoBCp1Tpe2mM1zxIzMBR1CjFgjQ/8dKZ4buV/iQpQn+bKuV2w/mZiOk6DWHYM5XrGA4lMTSkSiUHlvLjjWy/QJgI6yaL0ORmf8Jnfu5VNFC37b8Ubj6myIHx3ig0fm4IlZqNXW0HXBdlb/jmkyMaDO+hQYhN/Cdl9GI7QbU2Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RHgX9W3SUQOC9GlRcBb9gRcUO8j14e5IyrEuvEWheojM15JSc2CphmEGuPBcEG2GhFBHvO6UjbiPW237Fxz4P8B/67hY0qOUsn2W1ZcqVUMk41YRV1xOifxOcyzj0Ws/s4LVicuHE7rkN+xsYHloFZeENYvK9moOIIw5AcAeGqo= Received: by 10.86.95.20 with SMTP id s20mr2650011fgb.1192223443864; Fri, 12 Oct 2007 14:10:43 -0700 (PDT) Received: by 10.86.25.9 with HTTP; Fri, 12 Oct 2007 14:10:43 -0700 (PDT) Message-ID: Date: Fri, 12 Oct 2007 14:10:43 -0700 From: "Maksim Yevmenkin" To: "Bjoern A. Zeeb" In-Reply-To: <20071012200336.H6043@maildrop.int.zabbadoz.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200710121635.l9CGZbO2063862@repoman.freebsd.org> <20071012200336.H6043@maildrop.int.zabbadoz.net> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d ppp X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2007 21:37:09 -0000 On 10/12/07, Bjoern A. Zeeb wrote: > On Fri, 12 Oct 2007, Maksim Yevmenkin wrote: > > > emax 2007-10-12 16:35:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/defaults rc.conf > > etc/rc.d ppp > > Log: > > Teach /etc/rc.d/ppp to start multiple instances of ppp. > > > > ppp_profile variable can now contain multiple profiles. > > Overrides for ppp mode and nat can go into ppp_$profile_mode > > and ppp_$profile_nat variables respectively. If those are > > not specified, defaults from ppp_mode and ppp_nat are used. > > > > Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru > > > Reviewed by: mtm > > MFC after: 1 week > > > > Revision Changes Path > > 1.319 +6 -0 src/etc/defaults/rc.conf > > 1.14 +43 -9 src/etc/rc.d/ppp > > I wonder how that differs from the script proposed in > http://www.freebsd.org/cgi/query-pr.cgi?pr=114081 it does look similar :) i was not aware of your patch (and it is not clear from from the pr title that one should look there for similar patch :) in fact, it took me good ten minutes to find it. > which should also provide a fallback to the global > setting in case the _profile on is not given... the version i have committed provides fallback to default ppp_mode and ppp_nat if profile specific mode and nat overrides were omitted. you also deserve the credit for your work. thanks, max