From owner-svn-src-head@FreeBSD.ORG Tue Jul 22 18:56:22 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4217738; Tue, 22 Jul 2014 18:56:22 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6CC6F281A; Tue, 22 Jul 2014 18:56:22 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1X9fEZ-000OfQ-C1; Tue, 22 Jul 2014 22:56:19 +0400 Date: Tue, 22 Jul 2014 22:56:19 +0400 From: Slawa Olhovchenkov To: Marcel Moolenaar Subject: Re: svn commit: r268986 - head/sys/geom/uzip Message-ID: <20140722185619.GA94673@zxy.spb.ru> References: <201407221730.s6MHU6Ej099771@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201407221730.s6MHU6Ej099771@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2014 18:56:22 -0000 On Tue, Jul 22, 2014 at 05:30:06PM +0000, Marcel Moolenaar wrote: > Author: marcel > Date: Tue Jul 22 17:30:05 2014 > New Revision: 268986 > URL: http://svnweb.freebsd.org/changeset/base/268986 > > Log: > In r264504, we prevented doing I/O for more than MAXPHYS by making > the assumption that consumers would respect bio_completed and/or > bio_resid to detect short reads. This assumption proved false and > file corruption was the result. > Create as many bios as we need to satisfy the original request. > Check the cached chunk every time we need to do I/O to increase the > hit rate. Can you check other cases I/O for more than MAXPHYS? I think caused by incorrect partition scheme.