Date: Sun, 6 Jul 2008 11:03:55 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, cvs-ports@freebsd.org, Ion-Mihai Tetcu <itetcu@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/apr Makefile distinfo pkg-plist ports/devel/apr/files patch-apr-util_build_dbm.m4 patch-apr-util_configure patch-apr_hints.m4 Message-ID: <20080706010355.GD29380@server.vk2pj.dyndns.org> In-Reply-To: <20080705200240.GA88828@crodrigues.org> References: <200807041929.m64JTLxx060081@repoman.freebsd.org> <20080705081007.1dc30e3b@it.buh.tecnik93.com> <486FD18D.8000701@p6m7g8.com> <20080705200240.GA88828@crodrigues.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--qcTtWMBd/uZDG7+Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2008-Jul-05 20:02:40 +0000, Craig Rodrigues <rodrigc@crodrigues.org> wro= te: >On Sat, Jul 05, 2008 at 03:54:53PM -0400, Philip M. Gollucci wrote: >> The patch in the PR actually used Tools/scripts/bump_version.pl to bump= =20 >> all those ports, but it was for *some* reason not committed, > >I chose to err on the side of caution, and submit separate PR's to the >different port maintainers, since I don't like to blindly commit to >ports which I know nothing about. Except that when you change a shared library ABI or version, you need to bump all dependent ports at the same time. I accept that you (as committer) are accepting final responsibility for commits that you perform. This means ensuring that what you commit encompasses _all_ the changes needed - committing too little is just as bad as committing too much or an incorrect patch. >I hate it when people blindly commit to APR, so I don't want to do >the same thing to other ports. No-one is asking you to blindly commit anything. If you weren't sure about a PR then you should have discussed it with the originator and maybe with the maintainers of the other ports affected. >While you submit many good ports patches, I don't really trust your >track record. If you had an actual ports commit bit, then you >would have more credibility with me to submit mega-patches which >affect many ports. If someone who knows you better can sponsor >you for a commit bit, then you can take on more of this responsibility >for yourself, instead of dumping mega-patches for committers to pick up IMO, this is an unwarranted slur on Philip. There may be a variety of reasons why he does not have a commit bit and equating trustworthiness with a commit bit is demeaning to the large number of developers and ports maintainers who also don't have commit bits. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --qcTtWMBd/uZDG7+Y Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEARECAAYFAkhwGfsACgkQ/opHv/APuIdNYQCfbB3GE1CpCGtnubsEKKnhOFbR ZY4AoJM7/0Ihb6dDCnh95Gfxv0vc95UN =RGG4 -----END PGP SIGNATURE----- --qcTtWMBd/uZDG7+Y--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080706010355.GD29380>