From owner-svn-src-all@freebsd.org Tue Apr 7 09:22:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F1E72B0262; Tue, 7 Apr 2020 09:22:49 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48xMPz47hKz4Lcm; Tue, 7 Apr 2020 09:22:47 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp239-208.static.internode.on.net [59.167.239.208]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id 0379MVP3028903 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Apr 2020 19:22:37 +1000 (AEST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id 0379MQZ1090012 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 7 Apr 2020 19:22:26 +1000 (AEST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id 0379MQR2090011; Tue, 7 Apr 2020 19:22:26 +1000 (AEST) (envelope-from peter) Date: Tue, 7 Apr 2020 19:22:26 +1000 From: Peter Jeremy To: Wojciech Macek Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359647 - in head/sys: arm64/broadcom arm64/broadcom/brcmmdio conf dev/mdio Message-ID: <20200407092226.GA89740@server.rulingia.com> References: <202004060548.0365mwYZ065227@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <202004060548.0365mwYZ065227@repo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 48xMPz47hKz4Lcm X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of peter@rulingia.com designates 2001:19f0:5801:ebe:5400:1ff:fe53:30fd as permitted sender) smtp.mailfrom=peter@rulingia.com X-Spamd-Result: default: False [-7.49 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[rulingia.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-3.09)[ip: (-9.52), ipnet: 2001:19f0:5800::/38(-4.16), asn: 20473(-1.72), country: US(-0.05)]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 09:22:49 -0000 --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020-Apr-06 05:48:58 +0000, Wojciech Macek wrote: >Log: > Add MDIO PHY driver for NS2 ARM64 platform. =2E.. >Modified: head/sys/conf/files.arm64 >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/sys/conf/files.arm64 Mon Apr 6 04:06:15 2020 (r359646) >+++ head/sys/conf/files.arm64 Mon Apr 6 05:48:58 2020 (r359647) >@@ -176,6 +176,9 @@ arm64/arm64/undefined.c standard > arm64/arm64/unwind.c optional ddb | kdtrace_hooks | stack > arm64/arm64/vfp.c standard > arm64/arm64/vm_machdep.c standard >+arm64/broadcom/brcmmdio/mdio_mux_iproc.c optional fdt >+arm64/broadcom/brcmmdio/mdio_nexus_iproc.c optional fdt >+arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c optional fdt pci I don't believe this is correct. These files are only relevant to a subset of Broadcom SoCs and (IMO) should not be included merely with "options FDT", rather they should be conditional on the relevant Broadcom SoCs. --=20 Peter Jeremy --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE2M6l8vfIeOACl4uUHZIUommfjLIFAl6MRkhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQ4 Q0VBNUYyRjdDODc4RTAwMjk3OEI5NDFEOTIxNEEyNjk5RjhDQjIACgkQHZIUommf jLLyeg/+LSwJ+x2JUWhd1jE69GsnjKC2ZvzR794deEGgOBlOHHDM2LNrTnS3qTuq NP+sKQfJ5J36QrdmRY7oVLLvvJliBKOr6vYUvaEpV9HWxN/TuF1DwDgDD3NsacHh 9og/wZj3gU/k51AGhY3bPqiRw997vYkQlAp8VPxAk5VwkQhwbDVtwEqK8TqbEzt2 Kf4MTDmbzIhyPrUxnVsAPhGuEuISgSaHAeLfeFnN4NE6/BT6dXc80jI76f6mlvvO +HzqTJo/GEr+jciTJ+t5MiFKuVdkH+Cge1T2+r3K5K4/cTdSRYQ4RXNMEeSKnxAf FEDswInSh1XUjaUhrvzycMbs38RvDNipcmy2smQlmo495Zn3texea0Fnpb4dQemp QU3I9/Px5qdzvHuBrnwQLq+M0QW4ZnbSxZzwXE0S0DqDkCsW2kHnIf2hesKEwALS f7J/qLEJ8p7cSL5xzEFnrQfZYaPmoNz5xNzHmegTNP/4Jim6+f1mrb4rpXMIfJkw uTemKWgBuB7oxvcs5YGCXLJ1dtzpLd9oxvNeJT2Jyl4FyEpaYoaSqVuXHE3pQrJJ DuJZd2t0VI6gyUuba+kmGfMTp6KnOekVmrt8C5fc6F6K3fADbGez/yuhkXz2qkm4 77YMiPlhmYtdkg2CwWQu1hssR3AG0grrcuStgXVaK9ApsZKqNGw= =EJqe -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--