From owner-cvs-all@FreeBSD.ORG  Tue May 22 04:46:01 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0B74616A400;
	Tue, 22 May 2007 04:46:01 +0000 (UTC) (envelope-from alc@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id E9BBE13C45A;
	Tue, 22 May 2007 04:46:00 +0000 (UTC) (envelope-from alc@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4M4k0uc095932;
	Tue, 22 May 2007 04:46:00 GMT (envelope-from alc@repoman.freebsd.org)
Received: (from alc@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4M4k0AP095917;
	Tue, 22 May 2007 04:46:00 GMT (envelope-from alc)
Message-Id: <200705220446.l4M4k0AP095917@repoman.freebsd.org>
From: Alan Cox <alc@FreeBSD.org>
Date: Tue, 22 May 2007 04:46:00 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/vm vm_fault.c vm_map.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 May 2007 04:46:01 -0000

alc         2007-05-22 04:46:00 UTC

  FreeBSD src repository

  Modified files:
    sys/vm               vm_fault.c vm_map.c 
  Log:
  Eliminate the reactivation of cached pages in vm_fault_prefault() and
  vm_map_pmap_enter() unless the caller is madvise(MADV_WILLNEED).  With
  the exception of calls to vm_map_pmap_enter() from
  madvise(MADV_WILLNEED), vm_fault_prefault() and vm_map_pmap_enter()
  are both used to create speculative mappings.  Thus, always
  reactivating cached pages is a mistake.  In principle, cached pages
  should only be reactivated by an actual access.  Otherwise, the
  following misbehavior can occur.  On a hard fault for a text page the
  clustering algorithm fetches not only the required page but also
  several of the adjacent pages.  Now, suppose that one or more of the
  adjacent pages are never accessed.  Ultimately, these unused pages
  become cached pages through the efforts of the page daemon.  However,
  the next activation of the executable reactivates and maps these
  unused pages.  Consequently, they are never replaced.  In effect, they
  become pinned in memory.
  
  Revision  Changes    Path
  1.228     +3 -3      src/sys/vm/vm_fault.c
  1.384     +13 -5     src/sys/vm/vm_map.c