Date: Fri, 4 Dec 2009 02:27:07 +0000 From: Leonardo Santagostini <lsantagostini@gmail.com> To: Giorgos Keramidas <keramida@freebsd.org> Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org, Jung-uk Kim <jkim@freebsd.org> Subject: Re: Could you please fix this ? Message-ID: <9ab7eeeb0912031827vd32544fk996a65e871322091@mail.gmail.com> In-Reply-To: <87tyw8o5xk.fsf@kobe.laptop> References: <9ab7eeeb0912021757g5f60a7edw3256e60e745c0c35@mail.gmail.com> <87tyw8o5xk.fsf@kobe.laptop>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry, but ive not backed up this file, instead of this, i will copy
the entire function (in fact its very short)
cpi_pcib_pci_attach(device_t dev)
{
struct acpi_pcib_softc *sc;
ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__);
if (device_get_unit(dev)=3D=3D2){
pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
PCIM_CMD_PORTEN, 1);
pci_enable_busmaster(dev);
pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
pci_write_config(dev, PCIR_MEMBASE_1, 0xf020, 2);
pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf020, 2);
pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
}
if (device_get_unit(dev)=3D=3D3){
pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN |
PCIM_CMD_PORTEN, 1);
pci_enable_busmaster(dev);
pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1);
pci_write_config(dev, PCIR_MEMBASE_1, 0xf030, 2);
pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf030, 2);
pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2);
}
pcib_attach_common(dev);
sc =3D device_get_softc(dev);
sc->ap_handle =3D acpi_get_handle(dev);
return (acpi_pcib_attach(dev, &sc->ap_prt, sc->ap_pcibsc.secbus));
}
Kind Regards
Leonardo Santagostini
2009/12/3 Giorgos Keramidas <keramida@freebsd.org>:
> On Thu, 3 Dec 2009 01:57:50 +0000, Leonardo Santagostini <lsantagostini@g=
mail.com> wrote:
>> Hello everybody,
>>
>> I was facing one big problem, i have a notebook, which is an Acer
>> Aspire 5920. =C2=A0If you like i can send to you my messages file.
>>
>> Which is:
>>
>> Intel(R) Core(TM)2 Duo CPU =C2=A0 =C2=A0 T5550 =C2=A0@ 1.83GHz (1833.48-=
MHz 686-class CPU)
>> Intel(R) PRO/Wireless 3945ABG
>> Broadcom NetLink Gigabit Ethernet Controller
>> 2 Gigs RAM
>> 160 Gigs SATA
>>
>> The point was:
>> With ACPI disabled, i managed to boot but without WIFI; and with ACPI
>> enabled, the boot process hanged up all times.
>>
>> I fixed this adding
>>
>> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D2){
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_CMD=
_MEMEN | PCIM_CMD_PORTEN, 1);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_enable_busmaster(dev);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, =
1);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf020=
, 2);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf02=
0, 2);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1=
, 2);
>> =C2=A0 =C2=A0 }
>> =C2=A0 =C2=A0 if (device_get_unit(dev)=3D=3D3){
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_COMMAND, PCIM_CMD=
_MEMEN | PCIM_CMD_PORTEN, 1);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_enable_busmaster(dev);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, =
1);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMBASE_1, 0xf030=
, 2);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf03=
0, 2);
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1=
, 2);
>> =C2=A0 =C2=A0 }
>>
>> to /usr/src/sys/dev/acpica/acpi_pcib_pci.c running on a 8.0-RELEASE
>>
>> I was able to fix it by my way but many people cant do it, so, i would
>> really appreciate if you can add this piece of code.
>
> Hi Leonardo.
>
> Jung-uk Kim has done a lot of ACPI-related work, so he will probably
> know if the change is ok to commit to stable/8. =C2=A0I've added him to t=
he
> thread, so he can let us know what he thinks of the change. =C2=A0Can you
> please post a diff that also shows _where_ the changes have to be
> installed in our current version of src/sys/dev/acpica/acpi_pcib_pci.c
> for 8.0-RELEASE?
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9ab7eeeb0912031827vd32544fk996a65e871322091>