From owner-svn-ports-head@FreeBSD.ORG  Fri Nov  1 00:55:07 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 0293C136;
 Fri,  1 Nov 2013 00:55:07 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id CD3072FC4;
 Fri,  1 Nov 2013 00:55:05 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.26.50])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 09DD9438BC;
 Thu, 31 Oct 2013 19:54:42 -0500 (CDT)
Message-ID: <5272FBC0.2050306@marino.st>
Date: Fri, 01 Nov 2013 01:54:24 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: marino@freebsd.org
Subject: Re: svn commit: r332099 - head/devel/cssc/files
References: <201310301246.r9UCkiWu069471@svn.freebsd.org>
 <52710244.3040708@marino.st> <2602741.QmfnMIAQrR@mocha.verizon.net>
 <5271A160.8050309@marino.st>
In-Reply-To: <5271A160.8050309@marino.st>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, "Jason E. Hale" <jhale@freebsd.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Nov 2013 00:55:07 -0000

On 10/31/2013 01:16, John Marino wrote:
> On 10/31/2013 00:23, Jason E. Hale wrote:
>> Sorry, I guess my working copy was a little out of sync.  The patch submitted 
>> by the maintainer does ultimately include <unistd.h>.  I ran build tests 
>> before committing it, so I can confirm that it works.  If you don't mind, I'll 
>> just delete your patch so we don't have two patches for the same file.
> 
> A lot of these tests are flawed I've found (false passes).  However, if
> the maintainer patch contains <unistd.h>, I'm happy.  Feel free to
> remove the patch I added.
> 

Well, the maintainer patch does NOT contain <unistd.h>, contrary to what
you said earlier so now it's broken again with gcc47+.

Can you please retrieve the contents of my patch and integrate it into
the maintainer patch?

Thanks,
John

http://svnweb.freebsd.org/ports/head/devel/cssc/files/patch-unit-tests__googletest__include__gtest__internal__gtest-port.h?revision=332099&view=markup