Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Sep 2004 17:22:59 +0900
From:      daichi <daichi@freebsd.org>
To:        Max Khon <fjoe@samodelkin.net>
Cc:        freebsd-geom@FreeBSD.org
Subject:   Re: kern/71431: [panic fix] [patch] geom_uzip.ko caused panic
Message-ID:  <20040918172259.62d9ae40.daichi@freebsd.org>
In-Reply-To: <20040914184220.GB1075@samodelkin.net>
References:  <200409090607.i89674F3039635@freefall.freebsd.org> <20040914160245.7db7d1e0.daichi@freebsd.org> <20040914184220.GB1075@samodelkin.net>

next in thread | previous in thread | raw e-mail | index | archive | help
> Now I see the problem! Does this patch fix the problem for you?

Yes. Your patch got fix this problem.

I tried 5.3-BETA4 09/18 and got success.

  # kldload geom_uzip
  # mdconfig -a -f image.cloop
  ...
  # mount_cd9660 /dev/md0.uzip /mnt
  # ls /mnt
  ...
  # umount /mnt
  # mdconfig -d -u md0
  # kldunload geom_uzip

I think this patch is simple and very good. Please merge it :)

> Index: g_uzip.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/geom/uzip/g_uzip.c,v
> retrieving revision 1.1.2.1
> diff -u -p -r1.1.2.1 g_uzip.c
> --- g_uzip.c	10 Sep 2004 07:00:38 -0000	1.1.2.1
> +++ g_uzip.c	14 Sep 2004 18:19:36 -0000
> @@ -424,7 +424,7 @@ g_uzip_taste(struct g_class *mp, struct 
>  	for (blk = 1; offsets_read < total_offsets; blk++) {
>  		uint32_t nread;
>  
> -		free(buf, M_GEOM_UZIP);
> +		free(buf, M_GEOM);
>  		buf = g_read_data(
>  		    cp, blk * pp->sectorsize, pp->sectorsize, &error);
>  		if (buf == NULL || error != 0)
> @@ -470,7 +470,7 @@ err:
>  	g_topology_lock();
>  	g_access(cp, -1, 0, 0);
>  	if (buf != NULL)
> -		free(buf, M_GEOM_UZIP);
> +		free(buf, M_GEOM);
>  	if (gp->softc != NULL) {
>  		g_uzip_softc_free(gp->softc, NULL);
>  		gp->softc = NULL;
> 
> /fjoe

--
  Daichi GOTO, http://people.freebsd.org/~daichi


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040918172259.62d9ae40.daichi>