From owner-freebsd-geom@FreeBSD.ORG  Sat Sep 18 08:23:00 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5E7B516A4CE
	for <freebsd-geom@FreeBSD.org>; Sat, 18 Sep 2004 08:23:00 +0000 (GMT)
Received: from ongs.co.jp (ns.ongs.co.jp [202.216.232.58])
	by mx1.FreeBSD.org (Postfix) with SMTP id C14F643D58
	for <freebsd-geom@FreeBSD.org>; Sat, 18 Sep 2004 08:22:55 +0000 (GMT)
	(envelope-from daichi@freebsd.org)
Received: (qmail 35076 invoked from network); 18 Sep 2004 08:16:12 -0000
Received: from unknown (HELO parancell.ongs.co.jp) (202.216.232.62)
  by ns.ongs.co.jp with SMTP; 18 Sep 2004 08:16:12 -0000
Date: Sat, 18 Sep 2004 17:22:59 +0900
From: daichi <daichi@freebsd.org>
To: Max Khon <fjoe@samodelkin.net>
Message-Id: <20040918172259.62d9ae40.daichi@freebsd.org>
In-Reply-To: <20040914184220.GB1075@samodelkin.net>
References: <200409090607.i89674F3039635@freefall.freebsd.org>
	<20040914160245.7db7d1e0.daichi@freebsd.org>
	<20040914184220.GB1075@samodelkin.net>
Organization: FreeBSD Project
X-Mailer: Sylpheed version 0.9.12 (GTK+ 1.2.10; i386-portbld-freebsd5.2)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: fjoe@FreeBSD.org
cc: freebsd-geom@FreeBSD.org
Subject: Re: kern/71431: [panic fix] [patch] geom_uzip.ko caused panic
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Sep 2004 08:23:00 -0000

> Now I see the problem! Does this patch fix the problem for you?

Yes. Your patch got fix this problem.

I tried 5.3-BETA4 09/18 and got success.

  # kldload geom_uzip
  # mdconfig -a -f image.cloop
  ...
  # mount_cd9660 /dev/md0.uzip /mnt
  # ls /mnt
  ...
  # umount /mnt
  # mdconfig -d -u md0
  # kldunload geom_uzip

I think this patch is simple and very good. Please merge it :)

> Index: g_uzip.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/geom/uzip/g_uzip.c,v
> retrieving revision 1.1.2.1
> diff -u -p -r1.1.2.1 g_uzip.c
> --- g_uzip.c	10 Sep 2004 07:00:38 -0000	1.1.2.1
> +++ g_uzip.c	14 Sep 2004 18:19:36 -0000
> @@ -424,7 +424,7 @@ g_uzip_taste(struct g_class *mp, struct 
>  	for (blk = 1; offsets_read < total_offsets; blk++) {
>  		uint32_t nread;
>  
> -		free(buf, M_GEOM_UZIP);
> +		free(buf, M_GEOM);
>  		buf = g_read_data(
>  		    cp, blk * pp->sectorsize, pp->sectorsize, &error);
>  		if (buf == NULL || error != 0)
> @@ -470,7 +470,7 @@ err:
>  	g_topology_lock();
>  	g_access(cp, -1, 0, 0);
>  	if (buf != NULL)
> -		free(buf, M_GEOM_UZIP);
> +		free(buf, M_GEOM);
>  	if (gp->softc != NULL) {
>  		g_uzip_softc_free(gp->softc, NULL);
>  		gp->softc = NULL;
> 
> /fjoe

--
  Daichi GOTO, http://people.freebsd.org/~daichi