From owner-freebsd-current@freebsd.org Sat Jun 27 15:32:16 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 15907354479 for ; Sat, 27 Jun 2020 15:32:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49vHmv1Frfz45DG for ; Sat, 27 Jun 2020 15:32:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x834.google.com with SMTP id j10so9730495qtq.11 for ; Sat, 27 Jun 2020 08:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yCw2WRO3c7Vdbg73tOzHHZH98N69ksC5ScW9PYDTGl8=; b=RLTSuoDbQR9W/+FOqYRY44XhqMkWJYcqkyefPDWuo3YYtJHmyKZ4+3nPMKIZhN61bt /ogzQnYRw/M/gnPsjY1c9RGT4Wh7a2gyRsHkuzIFegH1WBEvQUWPj/eHrIm27mXoEzi5 ioy5ozHpTAVXk1s6kwlx+dLdCvkwdM10VHc8LvAFsHROUIVW3ZniNl7WuSTtZJu0frD7 J18hGNx2yP7qE57hy2w3qYvX1S5lLiF9hb0arYf4LlBrbstfz7S9Y/ZnBx9TxaZY77aS vo78O6q7C8/ZcliP6wnmJ9tmFLt3s+EdPdv2rS0cm6TvyrkWnyyrHIIPcfxJBd8CUScb BMXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yCw2WRO3c7Vdbg73tOzHHZH98N69ksC5ScW9PYDTGl8=; b=AqcJp8QGI8XuxPYwIItKEKQYq2YWldYDL8EY0juTEc8YF6N95Dca5qQgYB8NbjRti6 tkRFG0r39OeUXW8icR/1yBYQ1MJQ8fwAGOMX0mu0KcgDp/KvMlA6reaAXyzY9M6BQzuR J59RUxydWU8p/m2Lle82hAhSVOIW98o0pBUAuvmyO5sjXRHoq18fLYWVMqZguEuTeA4q pXIWCLPI2A4Dcqn2MzIVDP4yoxnBCQjs7w4B/4Dx5U/XXCn3xiWu/C+CSfxCOa27sOdn 3igecBWoPCKuWxx2sjt0+S7VSjynWeW6w0/73BhhFyc2fq0nXhBEF8nV1QSSOiMjw6Lf K95w== X-Gm-Message-State: AOAM530qnMXsoLAIu+ijTcuq9uwWVJhZB6WfRyYZ93ZFWvuu/IEDn6tU y2vSGM03rL7N1AIq2feVXIkCVVTK9+bDVcqzaQgZxg== X-Google-Smtp-Source: ABdhPJxhfbXKFq0UOtQUCbY2WsuAUgUhsb6DC+QyxQ7aRGd85ukuJbWuzYGMick6sKpTXVMSCk/cmZ3ENB+gsbLIN4Q= X-Received: by 2002:ac8:34e8:: with SMTP id x37mr8318761qtb.291.1593271934052; Sat, 27 Jun 2020 08:32:14 -0700 (PDT) MIME-Version: 1.0 References: <20200627090406.68b5d637@hermann.fritz.box> <14d1708f-74cc-4a60-3282-3308eb24743e@FreeBSD.org> <20200627115910.4fe32aa6@bsd64.grem.de> <61989d05-324a-0b8d-d0cf-0da5f3d9f00d@FreeBSD.org> <20200627164959.15752fb2@bsd64.grem.de> In-Reply-To: <20200627164959.15752fb2@bsd64.grem.de> From: Warner Losh Date: Sat, 27 Jun 2020 09:32:02 -0600 Message-ID: Subject: Re: weird Ctrl-T debug messages To: Michael Gmelin Cc: John Baldwin , Andriy Gapon , Li-Wen Hsu , "Conrad E. Meyer" , FreeBSD CURRENT X-Rspamd-Queue-Id: 49vHmv1Frfz45DG X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=RLTSuoDb; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::834) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-0.19 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-0.41)[-0.409]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.67)[-0.666]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[1]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.12)[-0.120]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::834:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 15:32:16 -0000 On Sat, Jun 27, 2020 at 8:50 AM Michael Gmelin wrote: > > > On Sat, 27 Jun 2020 06:21:17 -0700 > John Baldwin wrote: > > > On 6/27/20 2:59 AM, Michael Gmelin wrote: > > > > > > > > > On Sat, 27 Jun 2020 12:06:17 +0300 > > > Andriy Gapon wrote: > > > > > >> On 27/06/2020 10:44, Li-Wen Hsu wrote: > > >>> On Sat, Jun 27, 2020 at 3:04 PM Hartmann, O. > > >>> wrote: > > >>>> > > >>>> Running poudriere on recent CURRENT with (recent) 12-STABLE and > > >>>> CURRENT jails reveals a weird behaviour recently when hitting > > >>>> Ctrl-T: > > >>> ... > > >>>> Is this debug fallout from /bin/sh? > > >>> > > >>> It's because kern.tty_info_kstacks is on by default now: > > >>> > > >>> https://svnweb.freebsd.org/changeset/base/362141 > > >> > > >> May I suggest that the stack trace is printed procstat -kk style > > >> (single line) ? I think that the more compact output would be more > > >> convenient. > > > > > > It's a cool feature and having it on by default on CURRENT certainly > > > helps to discover it, which is great. Thanks for implementing this! > > > > > > I wouldn't enable it by default on RELEASE versions though, as > > > CTRL-T is a user interface to get status information (at least this > > > is how I use it personally, e.g., while running commands like > > > dd[0], cp, mv, poudriere etc.), not for getting debug output. > > > > I agree with this. > > > > > Question: Speaking of discovering the feature, wouldn't it make > > > sense to document this tunable on the stack(9) and/or tty(4) man > > > page(s)? > > > > This sounds like a great idea. Would you able to come up with a > > patch? I'd be happy to review it. > > Sure, it actually seems like that termios(4) is the best > place to put this information. > > https://reviews.freebsd.org/D25488 Damn, when I read this, I thought it was patches to control this on a per-tty basis by putting it in termios... That would be even cooler :) Warner