From nobody Tue Jun 3 20:04:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bBhWb4G2jz5y5bX; Tue, 03 Jun 2025 20:04:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bBhWZ5JcZz3rL8; Tue, 03 Jun 2025 20:04:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 553K4SWN049625; Tue, 3 Jun 2025 23:04:31 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 553K4SWN049625 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 553K4Sm5049624; Tue, 3 Jun 2025 23:04:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 Jun 2025 23:04:28 +0300 From: Konstantin Belousov To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 9a139facd06e - main - pseudofs: enhance KASSERT with more information Message-ID: References: <202506031125.553BPHor094136@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202506031125.553BPHor094136@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Queue-Id: 4bBhWZ5JcZz3rL8 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] On Tue, Jun 03, 2025 at 11:25:17AM +0000, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9a139facd06e4a1159a9c2cb992d04bcf1079e7e > > commit 9a139facd06e4a1159a9c2cb992d04bcf1079e7e > Author: Bjoern A. Zeeb > AuthorDate: 2025-06-03 11:20:56 +0000 > Commit: Bjoern A. Zeeb > CommitDate: 2025-06-03 11:25:00 +0000 > > pseudofs: enhance KASSERT with more information > > Add the name and type information to a KASSERT for 'homonymous siblings'. > Without this (or a core file) we do not even know which entry to look > for. This should make reporting and debugging a tad more simple. > > Prompted by: PR 287165 > --- > sys/fs/pseudofs/pseudofs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/fs/pseudofs/pseudofs.c b/sys/fs/pseudofs/pseudofs.c > index eb4ca8a82456..d8dbf7117d13 100644 > --- a/sys/fs/pseudofs/pseudofs.c > +++ b/sys/fs/pseudofs/pseudofs.c > @@ -124,7 +124,8 @@ pfs_add_node(struct pfs_node *parent, struct pfs_node *pn) > ("%s(): nested process directories", __func__)); > for (iter = parent->pn_nodes; iter != NULL; iter = iter->pn_next) { > KASSERT(strcmp(pn->pn_name, iter->pn_name) != 0, > - ("%s(): homonymous siblings", __func__)); > + ("%s(): homonymous siblings: '%s' type %d", __func__, > + pn->pn_name, pn->pn_type)); > if (pn->pn_type == pfstype_procdir) > KASSERT(iter->pn_type != pfstype_procdir, > ("%s(): sibling process directories", __func__)); May be it is time to finally make this check a runtime one. D50669