From owner-cvs-all Sun Jun 30 3:32:22 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47AE037B406; Sun, 30 Jun 2002 03:32:10 -0700 (PDT) Received: from iguana.icir.org (iguana.icir.org [192.150.187.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7335643E55; Sun, 30 Jun 2002 03:32:06 -0700 (PDT) (envelope-from rizzo@iguana.icir.org) Received: (from rizzo@localhost) by iguana.icir.org (8.11.6/8.11.3) id g5UAVYf80792; Sun, 30 Jun 2002 03:31:34 -0700 (PDT) (envelope-from rizzo) Date: Sun, 30 Jun 2002 03:31:34 -0700 From: Luigi Rizzo To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 Message-ID: <20020630033134.A80637@iguana.icir.org> References: <20020630020510.B79625@iguana.icir.org> <62778.1025430860@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <62778.1025430860@critter.freebsd.dk>; from phk@critter.freebsd.dk on Sun, Jun 30, 2002 at 11:54:20AM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 30, 2002 at 11:54:20AM +0200, Poul-Henning Kamp wrote: ... > If you want feedback on the idea, you should have posted the patch > to arch@ and similar places, not committed it to the tree, and > _never_ committed it directly to -stable. I did it last fall and was told about the ktr stuff, and that my code replicates those functionalities (i do not totally agree, they operate on a different granularity, but that's another story). Anyways, there is no equivalent of this stuff on -stable, and i strongly believe that we need tools like this to do performance tuning, and we need them badly. That is why i think this code certainly belongs to -stable, and why i did the commit. You are welcome to have different opinions, which i respect -- but these are just our opinions, so lets wait what others think. Feel free to bring this issue to -core, i will be glad to obey to whatever they decide, as i did in the past. But i want to emphasize that as usual this thread is about 20 lines of conditionally compiled code which will never ever interfere with anything else in the system. > Well, > > It could be because you are doing your work in -stable instead > of -current ? I am working on both. Just count how many commits i did on the networking stack on -current in this last two weeks. > It could also be because you tried to do the same thing with > your polling code ? > > :-) could be, you can never be sure... Sure it looks like you are reacting in the same way, maybe you win again :) You know one thing, you should add an "... and vice versa" you your signature, it seems to work quite well both ways: > Never attribute to malice what can adequately be explained by incompetence. cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message