From owner-svn-src-all@freebsd.org Sun Jun 3 06:51:16 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0ACDEFF9C8; Sun, 3 Jun 2018 06:51:16 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D703473CB6; Sun, 3 Jun 2018 06:51:15 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w536pCoC089862; Sat, 2 Jun 2018 23:51:12 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w536pCYd089861; Sat, 2 Jun 2018 23:51:12 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806030651.w536pCYd089861@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334540 - head/usr.bin/top In-Reply-To: To: Eitan Adler Date: Sat, 2 Jun 2018 23:51:12 -0700 (PDT) CC: "Rodney W. Grimes" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 06:51:16 -0000 [ Charset UTF-8 unsupported, converting... ] > On 2 June 2018 at 21:14, Rodney W. Grimes > wrote: > >> On 2 June 2018 at 16:53, Rodney W. Grimes > >> wrote: > >> > [ Charset UTF-8 unsupported, converting... ] > >> >> Author: eadler > >> >> Date: Sat Jun 2 21:40:45 2018 > >> >> New Revision: 334540 > >> >> URL: https://svnweb.freebsd.org/changeset/base/334540 > >> >> > >> >> Log: > >> >> top(1): cleanup memory allocation and warnings > >> >> > >> >> - Prefer calloc over malloc. This is more predicable and we're not in a > >> >> performance sensitive context. [1] > >> >> - Remove bogus comment (obsolete from prior commit). [2] > >> >> - Remove void casts and type casts of NULL > >> >> - Remove redundant declaration of 'quit' > >> >> - Add additional const > >> >> > >> >> Reported by: kib [1], vangyzen [2] > >> >> > >> >> Modified: > >> >> head/usr.bin/top/display.c > >> >> head/usr.bin/top/machine.c > >> >> head/usr.bin/top/screen.c > >> >> head/usr.bin/top/screen.h > >> >> head/usr.bin/top/utils.c > >> > ... > >> > > >> >> > >> >> Modified: head/usr.bin/top/screen.c > >> >> ============================================================================== > >> >> --- head/usr.bin/top/screen.c Sat Jun 2 21:16:20 2018 (r334539) > >> >> +++ head/usr.bin/top/screen.c Sat Jun 2 21:40:45 2018 (r334540) > >> >> @@ -3,7 +3,7 @@ > >> >> * Version 3 > >> >> * > >> >> * This program may be freely redistributed, > >> >> - * but this entire comment MUST remain intact. > >> >> + * but this entire ceomment MUST remain intact. > >> > > >> > I know you have already fixed this spelling error, > >> > but I believe there are some other commits that actually > >> > removed either this string, or some part of "this entire" > >> > comment that is to "remain intact". > >> > >> I just went through my commits to top(1) and don't see any others. Did > >> I miss any? > > > > Index: commands.c > > =================================================================== > > --- commands.c (revision 333898) > > +++ commands.c (working copy) > > @@ -1,6 +1,5 @@ > > /* > > * Top users/processes display for Unix > > - * Version 3 > > * > > * This program may be freely redistributed, > > * but this entire comment MUST remain intact. > > > > Found with a cd usr.bin/top; svn diff -r 333898 which is > > when you moved it to usr.bin. Further investigation > > shows that this line was deleted at r333909. > > I removed the version line, not the license line. Do you believe > "entire comment" includes the version information? I would interpret entire to be anything between /* and */. -- Rod Grimes rgrimes@freebsd.org