From owner-svn-src-head@FreeBSD.ORG  Wed Feb 12 18:42:21 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from hammer.pct.niksun.com (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by hub.freebsd.org (Postfix) with ESMTP id 5AD2B286;
 Wed, 12 Feb 2014 18:42:21 +0000 (UTC)
Message-ID: <52FBC08C.30309@FreeBSD.org>
Date: Wed, 12 Feb 2014 13:42:20 -0500
From: Jung-uk Kim <jkim@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: Dimitry Andric <dim@FreeBSD.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r261801 - head/contrib/libc++/include
References: <201402121814.s1CIEo5A016765@svn.freebsd.org>
In-Reply-To: <201402121814.s1CIEo5A016765@svn.freebsd.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2014 18:42:21 -0000

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2014-02-12 13:14:50 -0500, Dimitry Andric wrote:
> Author: dim Date: Wed Feb 12 18:14:49 2014 New Revision: 261801 
> URL: http://svnweb.freebsd.org/changeset/base/261801
> 
> Log: An ABI incompatibility crept into the libc++ 3.4 import in
> r261283.  It was caused by upstream libc++ commit r194536, which
> aimed to make the headers more standards-compliant, by making
> std::pair's copy constructor trivial.  Unfortunately, this could
> cause certain C++ applications using shared libraries built against
> the previous version of libc++ to crash.
> 
> Fix the ABI incompatibility by making std::pair's copy constructor 
> non-trivial again.
> 
> Please note: Any C++ applications or shared libraries built with
> libc++ between r261283 and this revision should be recompiled.
> 
> Reported by:	stefanf MFC after:	3 weeks X-MFC-With:	r261283
> 
> Modified: head/contrib/libc++/include/__config
> 
> Modified: head/contrib/libc++/include/__config 
> ==============================================================================
>
> 
- --- head/contrib/libc++/include/__config	Wed Feb 12 16:39:56 2014
(r261800)
> +++ head/contrib/libc++/include/__config	Wed Feb 12 18:14:49 2014
> (r261801) @@ -567,7 +567,7 @@ template <unsigned> struct
> __static_asse #define _LIBCPP_WCTYPE_IS_MASK #endif
> 
> -#if defined(__APPLE__) +#if defined(__APPLE__) ||
> defined(__FreeBSD__) #ifndef _LIBCPP_TRIVIAL_PAIR_COPY_CTOR #
> define _LIBCPP_TRIVIAL_PAIR_COPY_CTOR 0 #endif

It seems Apple removed it later.

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131125/094181.html

Do you know what they did?

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQEcBAEBAgAGBQJS+8CMAAoJEHyflib82/FGHckH/3knT4PPbIwJ8vgTqtENbp7o
Z9nK2UVwdk9EpXwx0d8Uy2eX6hs/2c5xEKqHHuuGlFBjHmwDUBsaW6746y8lWVaD
VtOtwRAN/wxyocA9kGscFBJv/dhmXpkvNUELjyQIOdgNWKdr5yYkOVF/blfpMTpn
49RIyFTj5IgxoedTp48lykpmYV95PF0TciqFFB8s78xCMVritHNzqk4au02z1olf
LmKLdmVHKqoU4wSMbmxzF+dv6MyfqkTtBxqV8HFUtVluHg2zhMZghPA0atmyMho3
7jlIFEYvjNmSVdicvXFtlmw61rE2XoKGx7G9m2hs1xLfyFTeYPpLxh2TWZaAHq4=
=o9xx
-----END PGP SIGNATURE-----