From owner-freebsd-current@freebsd.org Fri Nov 3 02:08:59 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB99FE68264; Fri, 3 Nov 2017 02:08:59 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 84EED71E63; Fri, 3 Nov 2017 02:08:59 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id C2F83159F9; Fri, 3 Nov 2017 02:08:58 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id E2D9F8CDA; Fri, 3 Nov 2017 02:08:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id NI2NPZ_HYrkt; Fri, 3 Nov 2017 02:08:53 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com DC3778CD7 Mime-Version: 1.0 (1.0) Subject: Re: Head build unsafe for /etc today From: Bryan Drewery X-Mailer: iPhone Mail (15A402) In-Reply-To: <20171103014907.GA88522@troutmask.apl.washington.edu> Date: Thu, 2 Nov 2017 19:08:50 -0700 Cc: FreeBSD Toolchain , freebsd-hackers , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org> References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org> <20171103014907.GA88522@troutmask.apl.washington.edu> To: sgk@troutmask.apl.washington.edu X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 02:08:59 -0000 > On Nov 2, 2017, at 18:49, Steve Kargl w= rote: >=20 >> On Thu, Nov 02, 2017 at 06:25:24PM -0700, Bryan Drewery wrote: >>=20 >> On Nov 2, 2017, at 15:44, Mark Millard wrote: >>=20 >>>> Author: bdrewery >>>> Date: Thu Nov 2 22:23:00 2017 >>>> New Revision: 325347 >>>> URL:=20 >>>> https://svnweb.freebsd.org/changeset/base/325347 >>>>=20 >>>>=20 >>>> Log: >>>> Something is very wrong >>=20 >>=20 >> Unfortunately I only test with META_MODE these days which implies -DNO_CL= EAN. >=20 > You're making changes to the build infrastructure and you're > not properly testing it before committing? This is beyond > pointyhat material.=20 I ran 2 universes, dozens of buildworlds and buildkernels, dozens of install= world and installkernel, several xdev and native-xtools, several full DIRDEP= S_BUILD builds and bootstraps, ran subdir builds, ran subdir cleans, tested s= everal targets together, ran various special case tests for submakes, played= around with a ton of MAKEOBJDIRPREFIX cases, handled and tested symlinked o= bjdirs special, ran it through my work repro a few times, did special testin= g in rescue/, and had a volunteer test release. In the process I found a b= make bug, GPL_DTC build bug and several others I don=E2=80=99t recall from t= he bus. What I missed was the =E2=80=9Cclean=E2=80=9D buildworld because I forgot it= even exists. I=E2=80=99ve wanted to remove it for a year. I also forgot to t= est buildenv. By the way the bug ran into here was 3-4 years old and I avoided the exact c= ase in some new code but missed that the problem was already existing subtly= in bsd.obj.mk. Having said all of that, I certainly don=E2=80=99t do so much testing normal= ly but these changes warranted the time I put in. >=20 > --=20 > Steve