Date: Mon, 22 May 2023 20:38:12 -0500 From: Kyle Evans <kevans@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 816129210ad4 - main - tests: Don't recurse into sys/compat32 Message-ID: <CACNAnaGSwu%2BcNtM6tAU2Vh0AXH2q7-tbcmCMhDJf%2B8EKx3LJ7g@mail.gmail.com> In-Reply-To: <202305160109.34G19Zs0095589@gitrepo.freebsd.org> References: <202305160109.34G19Zs0095589@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 15, 2023 at 8:09=E2=80=AFPM Jessica Clarke <jrtc27@freebsd.org>= wrote: > > The branch main has been updated by jrtc27: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D816129210ad4f951059db2d942= b8213ffe0a0f89 > > commit 816129210ad4f951059db2d942b8213ffe0a0f89 > Author: Jessica Clarke <jrtc27@FreeBSD.org> > AuthorDate: 2023-05-16 01:06:34 +0000 > Commit: Jessica Clarke <jrtc27@FreeBSD.org> > CommitDate: 2023-05-16 01:06:34 +0000 > > tests: Don't recurse into sys/compat32 > > Stubbing out the whole file means it has no targets, so recursive mak= es > fail with "don't know how to make X". We could fix that, but because = the > level above is adding it to TESTS_SUBDIRS it'll generate an include l= ine > for the subdirectory in its Kyuafile, which won't work (the problem t= hat > was previously seen on non-aarch64 in CI). Thus we really need to not > even add it to TESTS_SUBDIRS in the first place. > > Reported by: Dan Mack <mack@macktronics.com> > Fixes: 28f66935d400 ("tests: Disable sys/compat32 and sys/co= mpat32/aarch64 tests") Hi, For anyone interested, I posted a review for this part of the problem here: https://reviews.freebsd.org/D40224 This particular breakage wouldn't have happened if the flattening was done in a less fragile way to begin with. Thanks for helping me cover this up and discussing solutions, by the way- Thanks, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGSwu%2BcNtM6tAU2Vh0AXH2q7-tbcmCMhDJf%2B8EKx3LJ7g>