From owner-freebsd-current@freebsd.org Fri Feb 15 20:28:23 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F38914E7F55 for ; Fri, 15 Feb 2019 20:28:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7D48F83568 for ; Fri, 15 Feb 2019 20:28:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 3BFA914E7F54; Fri, 15 Feb 2019 20:28:22 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F183A14E7F53 for ; Fri, 15 Feb 2019 20:28:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 88A5283564 for ; Fri, 15 Feb 2019 20:28:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id v10so12406748qtp.8 for ; Fri, 15 Feb 2019 12:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Kcavfk/ld09JVdU+A2Ze6OAhIWnXOoGNLCYqWiiwXE=; b=TbvTa9ULdSaakFN3JIfaSlxVyP+4zmA92kLlt/TP3kg0nT2l6vf97j/ILtIpcQpxXz 8jV20ChYLEHpiNPYevFHOw9aV4u8luzLjg9bY925FTNQ03432W7Rg/OBUy0FoeONatlf sFNxN8DIHHck94tAEBnfBwK9+BBAUV4B57W1FjDyP+U3YgBxsMyf4Mt/DAiHXmQd0XmI P+3xV8VSGYcOL0AwOJst1TmtEzovQweo42zCtuCqZOFDKDoMScn5ovCclbRvuJgFm8fu 13c/qQ8PsZrtCkvCMIp6KYyibu0zHI0naLN7650cgV2A/WKAF8UwkXCxhh+ZG8kxWN9e egzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Kcavfk/ld09JVdU+A2Ze6OAhIWnXOoGNLCYqWiiwXE=; b=MME0SLEObh/WNSUPPnN1EMJpD54VN2KcAc7xMwFWvbgUAX7i/QULWSTFl9ChJbmM1F OQ+nUgAo7d7vBkR9HXDvJK7aNJ+vODcwACTqLDlMpaMlaunpALiRRxjwncbpMn47izlH DNqI7SPA3CUzfSXnMOkLOJmt2aZvl5Dc7HikZnIZ//qlMVqhYezp5LXou2KI/kVpL1Pd ajD3hrdjw/6jhy0ZkOxGgrObdpQ/wbWxUOE1HU6RlNMQhJn/YqJq8V987NQb35uzylix lAw7P/mvfwrp0ARrwSdfXFa25QOwlqXvwdfmH7l5LR9QwgKvrL8yVEXnZAkSjsS8GVVl NXTg== X-Gm-Message-State: AHQUAuaS4EQy2R/OG5gKLGUXoxDXzpclExIe2odIItj6mQuFgvALwgHN XXXFgKewUsTWlmL6tp2wEwNMER4+hTndIg1H3JcTug== X-Google-Smtp-Source: AHgI3IZka6Sa2tPzYii5TeNNqMckHmFRnx1BEC2aWrSJiDp8JpllnuS0IKKJ2ZLfhVvFnCTwnLTrcDgVx4XEfgcYsNs= X-Received: by 2002:ac8:16d0:: with SMTP id y16mr8794981qtk.345.1550262501045; Fri, 15 Feb 2019 12:28:21 -0800 (PST) MIME-Version: 1.0 References: <23653.56460.521599.489556@jerusalem.litteratus.org> <754B5C21-656B-4A67-BA39-50BB4AF5C0CD@gmail.com> <652F1541-52DE-4744-8AEA-8EE6434E04E8@gmail.com> <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> <50b76fd19c51acda91ca56d429b5539053ce74a9.camel@freebsd.org> In-Reply-To: <50b76fd19c51acda91ca56d429b5539053ce74a9.camel@freebsd.org> From: Warner Losh Date: Fri, 15 Feb 2019 13:28:10 -0700 Message-ID: Subject: Re: problem building dev/e1000 To: Ian Lepore Cc: Enji Cooper , Eric Joyner , Robert Huff , FreeBSD Current X-Rspamd-Queue-Id: 88A5283564 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 20:28:23 -0000 On Fri, Feb 15, 2019 at 12:54 PM Ian Lepore wrote: > On Fri, 2019-02-15 at 12:32 -0700, Warner Losh wrote: > > On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore wrote: > > > > > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote: > > > > > [...] > > > > > > > > HO Eric! > > > > > > > > iflib was a recently added requirement on stable/12 IIRC..? > > > > > > > > Does the manpage note this dependency, and is there an UPDATING > > > > entry > > > > for this change? > > > > > > > > Thanks! > > > > -Enji > > > > > > > > > > My question would be: why? If some drivers have a new dependency on > > > iflib, why isn't that expressed in sys/conf/files and handled > > > automatically? > > > > > > > Right now we have > > > > files:net/iflib.c optional ether pci iflib > > > > in the files file. This would need to change to > > > > files:net/iflib.c optional ether pci (em | igb | ...) > > > > but we don't have a () operator in config. Or we'd need dozens of > > lines, > > and the duplicate elimination code in config has been tricky (though > > I > > didn't check it just now). > > > > Warner > > > > I guess the question would be how many things does '...' represent now > and in the future? What it would need to be, given our current > inflexible config(8) is > > net/iflib.c optional ether pci em | ether pci igb | ... > > So if ... is 2 or 3 more drivers, that's not so bad. If iflib is > eventually going to be used by dozens of drivers, even the parens would > make for a pretty ugly solution. > Immediately, there's at least half a dozen. Count on there being a dozen or two eventually. MUST NOT RANT ABOUT CONFIG(8). Warner