Date: Sun, 19 Sep 1999 23:14:44 -0700 From: John-Mark Gurney <gurney_j@efn.org> To: Bill Paul <wpaul@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_sk.c if_skreg.h Message-ID: <19990919231444.17922@hydrogen.fircrest.net> In-Reply-To: <199909180401.VAA21565@freefall.freebsd.org>; from Bill Paul on Fri, Sep 17, 1999 at 09:01:32PM -0700 References: <199909180401.VAA21565@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bill Paul scribbled this message on Sep 17: > Fix the mechanism used to choose the unit numbers for the IP interfaces > attached by the SysKonnect driver. Use ifunit() to scan for existing > skN interfaces and pick the first unused one. this is probably not just related to the sk[c] driver, but all ethernet drivers that do this... we have a race condition w/ the allocation of an interface number... if there is another attach of a similar device going on at the same time (which can happen as we go to a more modularized setup), two devices could end up w/ the same unit number which I'm sure if_attach would fall over in (hopefully)... we need to initalize ifp->if_unit in if_attach and do it in a locked way instead of leaving this up to chance... I haven't taken a look at how if_attach behaves, but this should be fixed, and any other race conditions like it... -- John-Mark Gurney Voice: +1 408 975 9651 Cu Networking "The soul contains in itself the event that shall presently befall it. The event is only the actualizing of its thought." -- Ralph Waldo Emerson To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990919231444.17922>